Make card info dynamic by superMass14 · Pull Request #1 · 01-edu/vizard

superMass14 · 2025-11-28T16:02:58Z

No description provided.

Copilot

Pull request overview

This PR adds support for dynamic, custom info cards in circular graph visualizations. It introduces a new "custom" visualization mode that allows displaying arbitrary dictionary data for each project node, alongside the existing "classic" (single numeric values) and "distribution" (statistical data) modes.

Key Changes

Added a new kind="custom" option that accepts dictionary values with consistent keys across all projects
Implemented dynamic card width calculation based on content size for better visual presentation
Centralized text positioning using text-anchor="middle" for improved alignment

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 15 comments.

File	Description
circular_graph/tools/renderer_utils.py	Extended `show_info_card()` to support custom type with dynamic keys; added `show_custom_info_card()` function; improved card width calculations in all card types
circular_graph/modular_graph.py	Added custom kind validation in `__init__`; implemented `render_custom_content()` and `generate_custom_info_card()` methods; updated existing render methods to pass keys parameter
.gitignore	Added demo.ipynb to ignore list

Comments suppressed due to low confidence (1)

circular_graph/modular_graph.py:193

Except block directly handles BaseException.

            except:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-28T16:09:17Z

circular_graph/tools/renderer_utils.py

+    }});
+
+    const card_width = Math.max(base_card_width, maxContentWidth + 40);
+    const cardX = x + card_a_x_shift;


The cardX variable is defined but never used. This should be removed to improve code clarity.

Suggested change

const cardX = x + card_a_x_shift;

Copilot · 2025-11-28T16:09:17Z

circular_graph/tools/renderer_utils.py

+    x_shift = x >= limit_width -15 ? (card_width - card_a_x_shift) * -1  : card_a_x_shift;
+    const centeredX =  x >= limit_width -15 


Missing space around operator. Should be x >= limit_width - 15 for consistency with coding standards.

Suggested change

x_shift = x >= limit_width -15 ? (card_width - card_a_x_shift) * -1 : card_a_x_shift;

const centeredX = x >= limit_width -15

x_shift = x >= limit_width - 15 ? (card_width - card_a_x_shift) * -1 : card_a_x_shift;

const centeredX = x >= limit_width - 15

Copilot · 2025-11-28T16:09:18Z

circular_graph/tools/renderer_utils.py

+    projectText.setAttribute("text-anchor", "middle");
+    projectText.setAttribute("y", y + project_text_y_shift * project_text_y_factor);
+
+    sep.setAttribute("x1", x + x_shift +5);


Missing space around operator. Should be x + x_shift + 5 for consistency with coding standards.

Suggested change

sep.setAttribute("x1", x + x_shift +5);

sep.setAttribute("x1", x + x_shift + 5);

Copilot · 2025-11-28T16:09:18Z

circular_graph/tools/renderer_utils.py

+        tspan.textContent = key.charAt(0).toUpperCase() + key.slice(1) + " : " + (data[key] !== undefined ? data[key] : "N/A");
+        tspan.setAttribute("x", cardCenterX);
+        tspan.setAttribute("text-anchor", "middle");
+        tspan.setAttribute("y", y + (text_y_shift* text_y_factor) + text_y_margin * index);


Missing space around operator. Should be text_y_shift * text_y_factor for consistency with coding standards.

Suggested change

tspan.setAttribute("y", y + (text_y_shift* text_y_factor) + text_y_margin * index);

tspan.setAttribute("y", y + (text_y_shift * text_y_factor) + text_y_margin * index);

Copilot · 2025-11-28T16:09:19Z

circular_graph/modular_graph.py

            except:
                self.max_value = 0
+        elif self.kind == "custom":
+            # Validate that all values are dictionaries and have the same keys


Potential bug: If data is empty, next(iter(data.values())) will raise a StopIteration exception. Consider adding a check for empty data before this line, e.g., if not data: raise ValueError("data cannot be empty for kind='custom'")

Suggested change

# Validate that all values are dictionaries and have the same keys

# Validate that all values are dictionaries and have the same keys

if not data:

raise ValueError("data cannot be empty for kind='custom'")

Copilot · 2025-11-28T16:09:20Z

circular_graph/modular_graph.py

+                )
+            self.keys = list(first_val.keys())
+            for key, val in data.items():
+                if not isinstance(val, dict) or list(val.keys()) != self.keys:


The comparison list(val.keys()) != self.keys is order-sensitive. If dictionaries have the same keys but in different order, this will incorrectly fail. Consider using set(val.keys()) != set(self.keys) or sorted(val.keys()) != sorted(self.keys) for order-independent comparison.

Suggested change

if not isinstance(val, dict) or list(val.keys()) != self.keys:

if not isinstance(val, dict) or set(val.keys()) != set(self.keys):

Copilot · 2025-11-28T16:09:21Z

circular_graph/modular_graph.py

+            try:
+                first_key = self.keys[0]
+                self.max_value = max(v[first_key] for v in data.values())
+            except:


Bare except clause catches all exceptions including system-exiting exceptions like KeyboardInterrupt and SystemExit. Consider catching specific exceptions (e.g., except (ValueError, KeyError, TypeError)) to allow system exceptions to propagate properly.

Suggested change

except:

except (KeyError, TypeError, ValueError):

Copilot · 2025-11-28T16:09:21Z

circular_graph/tools/renderer_utils.py

+
+    return f"""
+    (function showInfoCard(el) {{ 
+    el.style.cursor= "pointer";


Missing space around the = operator. Should be el.style.cursor = "pointer"; for consistency with JavaScript coding standards.

Suggested change

el.style.cursor= "pointer";

el.style.cursor = "pointer";

Copilot · 2025-11-28T16:09:21Z

circular_graph/tools/renderer_utils.py

+    const centeredX =  x >= limit_width -15 
+    ?  cardX - (card_width - projectTextWidth)
+    : cardX + (card_width - projectTextWidth) / 2;


The centeredX variable is defined but never used. The code now uses cardCenterX (line 337) for centering text. This variable declaration should be removed to avoid confusion and improve code maintainability.

Suggested change

const centeredX = x >= limit_width -15

? cardX - (card_width - projectTextWidth)

: cardX + (card_width - projectTextWidth) / 2;

Copilot · 2025-11-28T16:09:21Z

circular_graph/modular_graph.py

+        """
+
+        if object_attrs is None:
+            object_attrs = {}


Variable object_attrs is not used.

superMass14 added 3 commits November 28, 2025 15:53

chore: add demo.ipynb to .gitignore

70ba04b

feat: enhance modular_graph to support custom visualization mode

d7403ab

feat: make info card rendering dynamic by adding support for custom type

527dd6a

superMass14 self-assigned this Nov 28, 2025

superMass14 requested a review from Copilot November 28, 2025 16:03

Copilot started reviewing on behalf of superMass14 November 28, 2025 16:03 View session

superMass14 merged commit afc31d9 into master Nov 28, 2025
8 of 10 checks passed

superMass14 deleted the make-card-info-dynamic branch November 28, 2025 16:05

Copilot finished reviewing on behalf of superMass14 November 28, 2025 16:07

Copilot AI reviewed Nov 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Make card info dynamic#1

Make card info dynamic#1
superMass14 merged 3 commits intomasterfrom
make-card-info-dynamic

superMass14 commented Nov 28, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		x_shift = x >= limit_width -15 ? (card_width - card_a_x_shift) * -1 : card_a_x_shift;
		const centeredX = x >= limit_width -15

	sep.setAttribute("x1", x + x_shift +5);
	sep.setAttribute("x1", x + x_shift + 5);

	tspan.setAttribute("y", y + (text_y_shift* text_y_factor) + text_y_margin * index);
	tspan.setAttribute("y", y + (text_y_shift * text_y_factor) + text_y_margin * index);

	if not isinstance(val, dict) or list(val.keys()) != self.keys:
	if not isinstance(val, dict) or set(val.keys()) != set(self.keys):

	const centeredX = x >= limit_width -15
	? cardX - (card_width - projectTextWidth)
	: cardX + (card_width - projectTextWidth) / 2;

Comments

Conversation

superMass14 commented Nov 28, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant