Conversation
* feat: add prove_dummy APIs on TransactionProver * fix: apply suggestions * fix: make clippy happy * fix: add changelog * chore: Use `prove_dummy` in mock chain * fix: use testing feature * fix: apply suggestions * fix: add test for TrasactionWitness * fix: lint * fix: cleanup * fix: refactor * chore: cleanup changelog * chore: cleanup changelog 2 * chore: cleanup changelog 3 * chore: cleanup --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
* refactor: remove transaction kernel versioning * chore: update changelog * refactor: update docs and comments, impl SequentialCommit for TransactionKernel * chore: update generated file * chore: update kernel_procedures.rs to make both generated file check and rustfmt happy * chore: update changelog * refactor: impl to_commitment as TransactionKernel method
* feat: remove bech32 types from public NetworkID * fix: add changelog * fix: refactor CustomNetworkId * fix: make clippy happy * apply suggestions * Update crates/miden-objects/src/account/account_id/network_id.rs --------- Co-authored-by: Marti <marcin.gorny.94@protonmail.com>
* fix: checking installation should use `cargo nextest` * chore: add machete to install tools * Update Makefile Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
* feat: Introduce Word wrapper for asset vault keys * fix: add changelog * fix: apply suggestions * fix: apply suggestions + tests * fix: nits * fix: rename AssetKey to VaultKey * fix: update tests * fix: update todo * fix: remove as_word function
* refactor: update type signatures in account_components * chore: update changelog * refactor: use lower-case parameter names, update event regex * refactor: use export instead of pub proc * chore: remove duplications from changelog * refactor: use BeWord instead of Word * refactor: replace export with pub proc * chore: remove changelog duplications after merge
* refactor: preparations before implementation * feat: impl has_procedure, add test, update changelog * chore: update changelog * docs: update protocol library docs, update doc comments * refactor: update inline comment
* feat: init ntx faucet * chore: update changelog * refactor: address nits & comments * refactor: add comment in burn procedure * feat: BURN & MINT notes * refactor: revert changes and address nits * refactor: cleanup * fix: new mock_chain method fix * refactor: minor comment updates * refactor: use account_id::is_equal * refactor: split faucet/mod.rs into two * fix: fix merge issues & nits * refactor: address nits * refactor: address nits * refactor: use AccountId in ntx faucet contructor * feat: add doc comments & update well_known_note * refactor: address nits * refactor: address pad nits * refactor: address nits * feat: add distribute padding procedure * fix: rustfmt * fix: make tests async * refactor: address nit * fix: fix stack comment * refactor: add padding in distribute * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Marti <marti@miden.team> * refactor: move burn proc to contracts/faucets/mod.masm * refactor: address MINT note nit * refactor: address basic fungible faucet comment * refactor: set default faucet decimals * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * refactor: address nits * refactor: address padding stack comment nits * refactor: clarify comment * refactor: address comment nits * feat: consume minted output note from ntx faucet * feat: add test & fix lint warnings * refactor: address stack comments * fix: changelog * fix: minor updates * chore: clean up stack comments in MINT note script * chore: address PR comment regarding test code comment being incorrect * chore: remove debug_assert_eq statement from well_known_note logic * chore: rustfmt * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * feat: improve network faucet mint / burn tests to show asset balance increase / decrease * Update crates/miden-lib/asm/note_scripts/MINT.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/note_scripts/MINT.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: improve faucet documentation and make BURN note generic * refactor: remove usage of local memory in faucets::distribute * refactor: fix stack comment in MINT note * refactor: fix padding comments in MINT note * Update crates/miden-lib/asm/miden/contracts/faucets/basic_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * chore: explicitly consume both authenticated and unauthenticated note in test (#2013) * chore: explicitly try consume both authenticated and unauthenticated note * chore: update test description * feat: re-export Section and SectionId (#2015) * chore: migrate docs from mdbook to docusaurus - Migrated documentation from mdbook to docusaurus - Updated protocol_library.md with detailed formatting and resolved merge conflicts - Added proper markdown links and structure - Incorporated new procedures from next branch - Added build and deployment workflows for docs * chore(Makefile): add serve-docs command and implement checking for NPM dependency * docs(README): add section explaining external documentation * chore(docs): convert .json docusaurus category files to yml format * fix(docs): fix broken links * chore: use specific ref for trigger-deploy-docs.yml workflow * docs: implement custom styling * Update crates/miden-lib/src/account/interface/mod.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: truncate stack explicitly in MINT note before call * fix: fix comment to reference correct faucet metadata slot index * refactor: update to use procedure_digest! macro for faucets * Update crates/miden-lib/src/account/faucets/network_fungible.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/src/account/faucets/network_fungible.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: use BasicFungibleFaucet inside NetworkFungibleFaucet to reduce duplication * fix: update to use fully qualified path of FungibleAsset::MAX_AMOUNT for ntx faucet doc comment * refactor: store owner_account_id as AccountId in NetworkFungibleFaucet * refactor: add padding to stack comments in /facuets/mod.masm * refactor: revert send_note test to use NoteType::Public * refactor: simplify create_network_fungible_faucet signature --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team> Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> Co-authored-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com> Co-authored-by: keinberger <philipp.keinberger@gmail.com>
* feat: Prepare for initializing empty slots * feat: Add account code tracking in delta for new accounts * feat: Implement delta <-> account conversion * feat: Set initial slots as empty in kernel * feat: Implement delta modification during prologue * feat: Return error for account -> delta with seed * chore: Improve account delta to account conversion * chore: Document slot_type * chore: add changelog * fix: typos and doc links * feat: Insert storage map entries into delta * chore: Test storage values on new account * chore: assert proven tx delta is present * chore: document `add_storage_map_entries_to_delta` * chore: remove TODO * chore: Set initial values as empty in storage delta tracker * fix: slot index increment * chore: Roll back account update details changes for priv accounts * fix: should loop flag computation * fix: only pre-insert entries when account is new * chore: remove duplicate account delta check * fix: typo * feat: Do not set empty initial slots * Revert "feat: Do not set empty initial slots" This reverts commit 893ef91. * Reapply "feat: Do not set empty initial slots" This reverts commit ca2e9b9. * feat: Implement `account_delta::insert_new_account` * feat: Use `cdropw` in delta commitment computation * chore: Update docs of insert_new_account * fix: typo * chore: Remove duplicate changelog entries * chore: Use named TODOs * feat: Improve delta docs * feat: Move tx account update validation to that type * feat: Inline validation into `TxAccountUpdate::new` * fix: noop tx tests including empty transactions * feat: Validate account delta commitment in proven transaction * chore: Cleanup tests * chore: Rename `init_slot_ptr` to `slot_ptr` * fix: duplicating remaining entries instead of slot idx * chore: Stronger doc wording * chore: Better wording for `TryFrom<&AccountDelta> for Account` * chore: Add is_full_state error condition to docs * chore: Make merging full state deltas an error * chore: Introduce helpfer function for empty header creation * chore: Rename mem_copy_native_account_initial_storage_slots * feat: Validate that advice-provided entries match map root exactly * chore: Remove TODO that was converted to issue * chore: Remove unused get_map_item_raw_unchecked * chore: expand comment in delta * chore: Move `impl TryFrom<Account> for AccountDelta` behind testing * feat: Move validation code into `insert_and_validate_storage_map`
* feat: Use multiple maps in storage map test * chore: Use two identical maps
* feat: unify vault_key vs. asset_key naming * fix: add changelog * Update CHANGELOG.md --------- Co-authored-by: Marti <marcin.gorny.94@protonmail.com>
* refactor: split miden::account * chore: update changelog * docs: update protocol library docs * chore: add new lines at the end of the new files * refactor: remove native_account::get_nonce, update changelog * refactor: synchronize procs order in active_account.masm and protocol library docs * chore: move vault root getters to the commitments section * refactor: use active instead of current, rearrange procs in kernel::account * refactor: make account_get_id handle both native and active accounts * chore: run tx benchmarks * refactor: udpate doc comments, udpate error message * docs: update doc comments and protocol library docs
* feat: Implement `RoutingParameters` * feat: Refactor `Address` and introduce `AddressId` * feat: Fail on trailing separator * chore: Generalize routing params error to `AddressError::DecodeError` * feat: Make Routing params optional and decouple tag len & if * chore: Test address encoding with/without routing params * feat: Add and update docs * chore: Remove `AddressInterface::Unspecified` * chore: add changelog * feat: Encode `AddressType::AccountId` as `232` * chore: Replace account ID with address ID * chore: Move default note tag len logic to `AddressId` * chore: Add docs to `RoutingParameters` * chore: Update docs with new account ID prefix `mm1a` * Update crates/miden-objects/src/address/mod.rs Co-authored-by: Marti <marti@miden.team> * chore: Format and improve `Address` docs --------- Co-authored-by: Marti <marti@miden.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.12.0 release