Conversation
* Initial plan * Add duplicate approver validation to multisig configuration Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Refactor duplicate check to use BTreeSet for conciseness Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Add changelog entry for duplicate approver validation Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Update CHANGELOG.md * Simplify duplicate approver test using clone Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Remove unnecessary clone() call (Copy trait) Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team>
* fix: unuse dependencies workflow * chore: Remove unused dependencies * chore: Add cargo machete to `make lint`
* feat: Add `create_mint_note` & `create_burn_note` helper functions (#2061) * chore: update crate version to v0.13.0 * Add duplicate approver validation to multisig configuration (#2046) * Initial plan * Add duplicate approver validation to multisig configuration Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Refactor duplicate check to use BTreeSet for conciseness Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Add changelog entry for duplicate approver validation Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Update CHANGELOG.md * Simplify duplicate approver test using clone Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Remove unnecessary clone() call (Copy trait) Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team> * feat: add mint / burn note helper functions * (parital) Revert "chore: update crate version to v0.13.0" This reverts commit 1f463f9. * Move changelog entry to unreleased 0.12.2 section (#2068) * Initial plan * Move changelog entry to 0.12.2 unreleased section Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: Bobbin Threadbare <bobbinth@protonmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team> * Update CHANGELOG.md Co-authored-by: Marti <marti@miden.team> --------- Co-authored-by: Bobbin Threadbare <bobbinth@protonmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team>
Update `agglayer` branch to `next`
* Add FPI proving test with two foreign accounts * corrections
…cution (#2113) * feat: Fetch asset vault keys from data store * feat: Fetch fee asset witness in data store * feat: Add asset witnesses to `TransactionInputs` * feat: Remove asset witness loading during tx fee removal event * chore: add changelog * chore: handle fee asset error * fix: changelog entry * fix: remove unused import * chore: Revert to simpler `get_transaction_inputs` interface * feat: Make `get_vault_asset_witness` take multiple keys * chore: improve asset_vault::add_asset comment
…d `NullifierTree`s (#2110)
* feat: move standard note scripts into standard library Move note script logic from standalone files in `note_scripts/` directory to `miden::standards::notes` namespace modules. This enables dynamic access to script roots via `procref` instead of hardcoding values. Changes: - Add new modules under `standards/notes/`: p2id, p2ide, swap, burn, mint - Each module contains a `pub proc main` with the script logic - Original note script files now serve as minimal wrappers calling `exec.<note>::main` Closes #2243 * chore: add changelog entry for note scripts refactoring * docs: fix namespace references in note script documentation * chore: update docs contracts->standards --------- Co-authored-by: Marti <marti@miden.team>
Previously, the Minimum Supported Rust Version (MSRV) check ran on every pull request and push to next. This was expensive because cargo-msrv downloads additional Rust toolchains to verify compatibility. Now the MSRV check only runs: - On push to main/next (in release-plz-dry-run.yml) - When publishing a release (in release-plz.yml) This makes PR CI faster and uses less memory. Any MSRV issues will still be caught before publication, and can be fixed locally using the scripts/check-msrv.sh script. Changes: - Delete .github/workflows/msrv.yml - Add MSRV check steps to release-plz-dry-run.yml - Add MSRV check steps to release-plz.yml
* feat: Define `NoteTag` to wrap arbitrary `u32` * feat: Rework note tag docs and constructors * chore: Remove use case constructors and refactor swap tag * feat: Remove note tag validation * feat: Rename account ID conversion to account target * feat: Update note tag docs * chore: add changelog * chore: Make `NoteMetadata::new` infallible * chore: address review comments on docs * chore: remove outdated note tag rules in metadata docs * chore: remove `create_mock_notes` (#2236) * chore: Rename `create_random_note` to `*_default_*` and add pub helper * chore: replace create_mock_notes in test_epilogue * chore: Remove `create_mock_notes` --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
* feat: Implement `NoteAttachment` * chore: Precompute `NoteHeader` in `PartialNote` * feat: Remove aux, exec hint from `NoteMetadata`; add attachment * feat: refactor output note memory layout and metadata building * chore: adapt tx event extraction to new output_note::create stack state * chore: prepare `compute_output_notes_commitment` for attachment hashing * chore: Update input notes commitment to include attachment * chore: include attachment in output notes commitment * chore: return attachment and header from `input_note_get_metadata` * chore: return attachment and header from `output_note_get_metadata` * fix: compilation errors in `miden-testing` * chore: regenerate kernel procedure hashes * chore: add changelog * chore: rename attachment_types to attachment_type_info for clarity * chore: Move content to word encoding to method * chore: rename `Raw` -> `Word` and `Commitment` -> `Array` * chore: Rename `NoteAttachmentCommitment` to `*Array`
* feat: Implement `output_note_set_attachment` kernel API * feat: Implement `miden::protocol` set_attachment wrappers * feat: Emit event during `set_attachment` for tx host * chore: add tests for `set_attachment` APIs * chore: regenerate kernel procedure hashes * chore: add changelog * chore: rename `Raw` -> `Word` and `Commitment` -> `Array` * fix: renamed attachment content variants * chore: make attachment content type constants public * chore: move note ptr to idx conversion to helper * chore: merge attachment validation procedures into one * chore: simplify setting output note attachment type info * chore: make `set_attachment` public * fix: commitment to array rename * chore: require attachment_type == 0 when content type is None * chore: enforce none / attachment type restriction in `NoteAttachment`
* feat: Implement `NetworkAccountTarget` * chore: Let SPAWN note create output notes with attachment * chore: test creating note with NetworkAccountTarget attachment * chore: add changelog * fix: don't use super::* import * feat: Add `WellKnownNoteAttachment` * chore: Use 8-bit tag for exec hint; remove `AfterBlockNumber` * chore: improve network account target error
…::create` (#2260) * chore: remove aux and exec hint from protocol::output_note::create * fix: tests in `test_epilogue.rs` * fix: update calls to `output_note::create` in note tests * fix: update calls to `output_note::create` in tx and account_delta test * fix: remove aux and exec hint from `send_note_body` * chore: remove exec hint and aux from swap note * chore: update MINT note to new output_note::create signature * fix: remove aux/exec hint from faucet tests * fix: replace aux with attachment in p2id constructors * fix: replace aux with attachment in mint, burn, p2ide notes * chore: remove aux and exec hint metadata methods * chore: remove aux/exec hint from `NoteBuilder` * chore: add changelog * feat: Take attachment param in `faucets::distribute` * chore: update MINT note to new faucets::distribute params * feat: allow attachment for payback note in SWAP note * fix: calls to `distribute` in tests; remove mention of aux * Revert "feat: Take attachment param in `faucets::distribute`" This reverts commit 8c27281. * chore: return note_idx from `distribute` * Partially revert chore: update MINT note to new faucets::distribute params * chore: update MINT note with new note inputs memory offets * chore: set attachment in MINT note * Partially revert fix: calls to `distribute` in tests; remove mention of aux * feat: Add attachment to note in `send_body` * chore: remove unnecessary `push.0`
…2268) * feat: Pad elements in `NoteAttachmentArray` before committing * chore: Rename `NoteAttachmentType` -> `NoteAttachmentScheme` * chore: rename "attachment type info" to "attachment kind scheme" * chore: Rename `NoteAttachmentContentType` -> `NoteAttachmentKind` * chore: rename attachment scheme untyped to unknown * chore: Swap kind and scheme in procedure signatures * chore: add changelog * Revert "feat: Pad elements in `NoteAttachmentArray` before committing" This reverts commit cfe9702. * chore: rename `NoteAttachmentScheme::unknown` to `none` * fix: more content type -> attachment kind renames
* feat: Add attachment section to note docs * chore: document advice map entry requirement for array attachments * chore: add set_attachment to protocol library docs * chore: add changelog * feat: make attachment array elements available for input notes * chore: improve readability * fix: remove attachment_kind param from `set_array_attachment`
* feat: add Solidity<>Miden address type conversion functions * fix: formatting * refactor: rm unnecessary indirection * refactor: use crypto util functions * refactor: implement suggestions & refactor * refactor: update logic & comments to little endian * Update crates/miden-agglayer/src/utils.rs Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com> * refactor: improve EthAddress representation clarity and MASM alignment * refactor: simplify ethereum_address_to_account_id proc * fix: clippy * fix: lint doc check * refactor: use u32assert2 * refactor: simplify from_account_id() & u32 check * revert: undo drop addr4 in ethereum_address_to_account_id * Update crates/miden-agglayer/src/eth_address.rs Co-authored-by: Marti <marti@miden.team> * refactor: rename to EthAddressFormat * refactor: rearrange EthAddressFormat * refactor: rename file to eth_address_format * fix: update script roots * refactor: update test & refactor * refactor: refactor .to_elements() method * refactor: rename to to_account_id * fix: lint check * refactor: rename to eth_address.rs & undo Felt::try_from() changes --------- Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com> Co-authored-by: Marti <marti@miden.team> Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
Agglayer bridging tracking PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.13.0 release.