Skip to content

feat(standards): prefix account components with miden::standards namespace#2400

Open
Himess wants to merge 1 commit into0xMiden:nextfrom
Himess:feat/prefix-standard-account-components
Open

feat(standards): prefix account components with miden::standards namespace#2400
Himess wants to merge 1 commit into0xMiden:nextfrom
Himess:feat/prefix-standard-account-components

Conversation

@Himess
Copy link
Contributor

@Himess Himess commented Feb 4, 2026

Closes #2399

@Himess Himess marked this pull request as draft February 4, 2026 17:40
@Himess Himess marked this pull request as ready for review February 4, 2026 17:50
@PhilippGackstatter
Copy link
Contributor

Thank you! Let's wait for #2373 to be merged and rebase on top of it once it is.

@Himess
Copy link
Contributor Author

Himess commented Feb 8, 2026

Hey @PhilippGackstatter, I noticed this PR has conflicts with next after #2373 landed.
The AccountComponentMetadata API changed to a builder pattern and AccountComponent::new now takes metadata as a 3rd argument, so the .with_metadata() approach here no longer applies.

Also, the current NAME constants on next are short-form ("miden::basic_fungible_faucet", "miden::basic_wallet") rather than the full library path ("miden::standards::account_components::faucets::basic_fungible_faucet") that this PR and #2399 propose.

Should I rebase and adapt to the new API, or has the naming direction changed since the issue was opened?

@PhilippGackstatter
Copy link
Contributor

Hi @Himess, I think we should rebase and adapt to the new API. I also still think we should use the full library path instead of a short form one.

@Himess Himess force-pushed the feat/prefix-standard-account-components branch 3 times, most recently from e800ed0 to 756709a Compare February 11, 2026 10:37
…ount_components

Updates library paths of standard account components to use full
miden::standards::account_components::<category>::<name> convention.

Closes 0xMiden#2399
@Himess Himess force-pushed the feat/prefix-standard-account-components branch from 756709a to 74d1a08 Compare February 11, 2026 10:46
@Himess
Copy link
Contributor Author

Himess commented Feb 11, 2026

Hi @PhilippGackstatter wdyt about new changes ? Is it good or ?

@Himess
Copy link
Contributor Author

Himess commented Feb 11, 2026

Note: the enforcement in AccountComponent::new (checking that metadata name is a prefix of the library path) is left as a follow-up, since it requires fixes across multiple crates (miden-agglayer, testing components, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefix standard account components with miden::standards

2 participants