feat(standards): prefix account components with miden::standards namespace#2400
feat(standards): prefix account components with miden::standards namespace#2400Himess wants to merge 1 commit into0xMiden:nextfrom
Conversation
|
Thank you! Let's wait for #2373 to be merged and rebase on top of it once it is. |
|
Hey @PhilippGackstatter, I noticed this PR has conflicts with next after #2373 landed. Also, the current NAME constants on next are short-form Should I rebase and adapt to the new API, or has the naming direction changed since the issue was opened? |
|
Hi @Himess, I think we should rebase and adapt to the new API. I also still think we should use the full library path instead of a short form one. |
e800ed0 to
756709a
Compare
…ount_components Updates library paths of standard account components to use full miden::standards::account_components::<category>::<name> convention. Closes 0xMiden#2399
756709a to
74d1a08
Compare
|
Hi @PhilippGackstatter wdyt about new changes ? Is it good or ? |
|
Note: the enforcement in AccountComponent::new (checking that metadata name is a prefix of the library path) is left as a follow-up, since it requires fixes across multiple crates (miden-agglayer, testing components, etc.). |
Closes #2399