refactor: remove ProvenTransactionBuilder in favor of ProvenTransaction::new#2402
Open
Himess wants to merge 2 commits into0xMiden:nextfrom
Open
refactor: remove ProvenTransactionBuilder in favor of ProvenTransaction::new#2402Himess wants to merge 2 commits into0xMiden:nextfrom
ProvenTransactionBuilder in favor of ProvenTransaction::new#2402Himess wants to merge 2 commits into0xMiden:nextfrom
Conversation
Himess
force-pushed
the
remove-proven-transaction-builder
branch
from
ddb4044 to
226a771
Compare
…ction::new` - Add `ProvenTransaction::new()` constructor with validation - Remove `ProvenTransactionBuilder` struct and impl - Update all usages to use the new constructor Closes 0xMiden#1999
Himess
force-pushed
the
remove-proven-transaction-builder
branch
from
226a771 to
ca50eaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ProvenTransactionBuilderand addsProvenTransaction::new()constructor with validation.Closes #1999