feat: include fee asset in TransactionId hash#2414
Open
crStiv wants to merge 13 commits into0xMiden:nextfrom
Open
feat: include fee asset in TransactionId hash#2414crStiv wants to merge 13 commits into0xMiden:nextfrom
crStiv wants to merge 13 commits into0xMiden:nextfrom
Conversation
Updated transaction ID computation to include fee asset.
Updated documentation to clarify that the transaction header retains public commitments and includes the fee asset.
Added comments to clarify the purpose of the transaction identifier and its relation to the transaction header.
PhilippGackstatter
approved these changes
Feb 18, 2026
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
bobbinth
reviewed
Feb 19, 2026
| final_account_commitment: Word, | ||
| input_notes_commitment: Word, | ||
| output_notes_commitment: Word, | ||
| fee_asset: Word, |
Contributor
There was a problem hiding this comment.
Question: would it be better to pass the fee here as a FungibleAsset?
Contributor
There was a problem hiding this comment.
@crStiv Can you change this to take the FungibleAsset instead of Word?
bobbinth
reviewed
Feb 23, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Thank you! Overall, I think this looks good - but two comments:
- We should probably merge this after the asset refactoring PRs are merged.
- If we change the fee to be paid via something like a
FEEnote, the need for this may go away (though, this is a bigger issue that we still need to align on).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include fee asset in TransactionId hash computation so it commits to entire TransactionHeader contents.
Closes #2348