refactor: address review nits for asset key/value refactoring#2438
Merged
PhilippGackstatter merged 6 commits intopgackst-kernel-asset-key-valuefrom Feb 14, 2026
Merged
refactor: address review nits for asset key/value refactoring#2438PhilippGackstatter merged 6 commits intopgackst-kernel-asset-key-valuefrom
PhilippGackstatter merged 6 commits intopgackst-kernel-asset-key-valuefrom
Conversation
…it ASSET_PTR constants, rename variables, add test Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
…logue Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
mmagician
approved these changes
Feb 12, 2026
Copilot
AI
changed the title
[WIP] Refactor tx kernel from ASSET to ASSET_KEY and ASSET_VALUE
refactor: address review nits for asset key/value refactoring
Feb 12, 2026
Collaborator
|
@copilot run |
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Contributor
Author
Done! Ran Note: The Fixed in commit 7a57963. |
PhilippGackstatter
approved these changes
Feb 13, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks great, thanks! Left one small comment.
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
PhilippGackstatter
approved these changes
Feb 14, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Nice improvements, thank you!
e0ac414
into
pgackst-kernel-asset-key-value
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_asset_key_and_valuein asset.masmassetin tx_event.rs (Asset type represents the whole asset, not just value)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.