Skip to content

refactor: address review nits for asset key/value refactoring#2438

Merged
PhilippGackstatter merged 6 commits intopgackst-kernel-asset-key-valuefrom
copilot/sub-pr-2396
Feb 14, 2026
Merged

refactor: address review nits for asset key/value refactoring#2438
PhilippGackstatter merged 6 commits intopgackst-kernel-asset-key-valuefrom
copilot/sub-pr-2396

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

  • Create utility procedure load_asset_key_and_value in asset.masm
  • Update epilogue.masm to use the utility procedure
  • Update prologue.masm to use the utility procedure
  • Update B2AGG.masm to use explicit ASSET_PTR constant
  • Update faucets/mod.masm to use explicit ASSET_PTR constant
  • Update swap.masm to use explicit ASSET_PTR constant
  • Add test for merging two different assets in test_asset_vault.rs
  • Keep variable name as asset in tx_event.rs (Asset type represents the whole asset, not just value)
  • Fix stack manipulation in load_asset_key_and_value (movup.8 instead of movup.5)
  • Fix stack index in prologue.masm (dup.1 instead of dup.4)
  • Fix stack index in epilogue.masm (dup.1 instead of dup.4)
  • Run cargo fmt to fix all formatting issues

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 12, 2026 19:30
…it ASSET_PTR constants, rename variables, add test

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
…logue

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor tx kernel from ASSET to ASSET_KEY and ASSET_VALUE refactor: address review nits for asset key/value refactoring Feb 12, 2026
Copilot AI requested a review from mmagician February 12, 2026 19:47
@mmagician
Copy link
Collaborator

@copilot run make lint and make sure CI passes

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot run make lint and make sure CI passes

Done! Ran cargo fmt to fix formatting issues. The lint checks should now pass.

Note: The make lint command failed locally due to missing typos tool (requires Rust 1.91+, but we have 1.90). However, I've fixed the main formatting issues that were causing the CI lint workflow to fail.

Fixed in commit 7a57963.

Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Left one small comment.

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
@mmagician mmagician marked this pull request as ready for review February 14, 2026 10:54
@mmagician mmagician added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 14, 2026
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thank you!

@PhilippGackstatter PhilippGackstatter merged commit e0ac414 into pgackst-kernel-asset-key-value Feb 14, 2026
15 checks passed
@PhilippGackstatter PhilippGackstatter deleted the copilot/sub-pr-2396 branch February 14, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants