refactor: avoid writing into src dir upon building#2452
refactor: avoid writing into src dir upon building#2452
src dir upon building#2452Conversation
mmagician
added
the
no changelog
mmagician
force-pushed
the
mmagician-build-skip-src-write
branch
from
d703d7b to
279ee0d
Compare
mmagician
changed the title
src dir upon building
mmagician
requested review from
Mirko-von-Leipzig,
PhilippGackstatter and
bobbinth
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Nice does this mean I'm allowed to do the same with the proto files 😬
There was a problem hiding this comment.
Why does one need to copy source files into {OUT_DIR} as part of the build script?
There was a problem hiding this comment.
I'm not sure either. Maybe because we previously wrote into the src directory and didn't want that to interfere with the assembly process? I think we could try skipping the copy and try building directly from src and see what happens.
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
I think this would make rebasing and merging a more convenient due to fewer conflicts in the generated files, which are no longer committed. Also, we shouldn't run into the re-build issues anymore as fixed in #2448 most recently.
mmagician
added
the
pr-from-maintainers
3 participants
Avoid writing to
srcdir upon building.Instead, write into
OUT_DIRand include the generated files.Related to #994