Conversation
igamigo
force-pushed
the
igamigo-rename-type-id
branch
from
0f9cd52 to
ba1f740
Compare
mmagician
added
the
pr-from-maintainers
Contributor
|
Now that #2390 is merged, could you rebase this PR onto next? |
igamigo
force-pushed
the
igamigo-rename-type-id
branch
from
5530ee7 to
7e6c6e0
Compare
igamigo
force-pushed
the
igamigo-rename-type-id
branch
from
7e6c6e0 to
ac0631d
Compare
Collaborator
Author
Yes, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PhilippGackstatter brought up the good point that the
Idpart ofSchemaTypeIdis a bit redundant.I know #2390 adds some code related to this so maybe we can wait until that's merged to revisit this. I tried pushing a branch to the fork on top of @onurinanc 's branch but I do not have permissions, so I can't properly base this branch off of that one.