Improved predicate splitting #445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robknight
force-pushed
the
multi_batch_splitting
branch
2 times, most recently
from
632f1d6 to
a993b78
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
2 times, most recently
from
db5c6e7 to
a19bc1c
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
4 times, most recently
from
8369cb6 to
125d34f
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
from
125d34f to
5eb5bdd
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
from
fc2ab53 to
ddb2e24
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
from
4fdbaf8 to
d46530b
Compare
robknight
force-pushed
the
multi_batch_splitting
branch
from
d46530b to
0beb632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two problems:
Previously, long predicates could be split into multiple predicates. However, long batches could not automatically be split into multiple batches. This functionality has been added.
Invoking a split predicate was annoying: you would need to find the tail predicate, perform a custom operation for it, then work back up to the head predicate, making a new operation for each chunk. This PR adds a mechanism to invoke the entire chain at once, passing in the full set of arguments, automatically creating the intermediate operations.
The API for the latter is designed to be compatible with both
MainPodBuilderandMultiPodBuilderfrom #444.