Add aggLayer settlement option #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcastellm
approved these changes
Feb 19, 2024
| }, | ||
| "SettlementBackend": { | ||
| "type": "string", | ||
| "description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.", |
Collaborator
There was a problem hiding this comment.
WDYT?
Suggested change
| "description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.", | |
| "description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Agglayer service.", |
| // final gas: 1100 | ||
| GasOffset uint64 `mapstructure:"GasOffset"` | ||
|
|
||
| // SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service. | |
| // SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Agglayer service. |
| waitCtx, cancelFunc := context.WithDeadline(ctx, time.Now().Add(a.cfg.AggLayerTxTimeout.Duration)) | ||
| defer cancelFunc() | ||
| if err := a.AggLayerClient.WaitTxToBeMined(txHash, waitCtx); err != nil { | ||
| log.Errorf("interop didn't mine the tx: %v", err) |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.Errorf("interop didn't mine the tx: %v", err) | |
| log.Errorf("agglayer didn't mine the tx: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.