This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Show some message while app is building #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5. Depends on 0xProject/0x-launch-kit-frontend#499 being merged and the new image being published.
This copies a template showing a message before starting to build the app. After the build finishes, the message is overwritten by the built app.
Some extra details in case anyone cares:
First, I had to serve the assets from
production-buildinstead ofbuild, becausecreate-react-appcleans the wholebuilddirectory when it starts, and so the message was being deleted.I also added a
depends_on: nginxto the frontend container. Nginx adds its ownindex.htmlwhen it starts, and it can overwrite the copied template. With this dependency, we guarantee that the shownindex.htmlis the one we copied.