Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Grabbing main repo language and displaying it#41

Open
Mordax wants to merge 2 commits into0xazure:masterfrom
Mordax:issue-40
Open

Grabbing main repo language and displaying it#41
Mordax wants to merge 2 commits into0xazure:masterfrom
Mordax:issue-40

Conversation

@Mordax
Copy link
Contributor

@Mordax Mordax commented Dec 17, 2018

Closes #40. Adds the main repo language to the Repo struct and implements in a display.

@0xazure
Copy link
Owner

0xazure commented Dec 19, 2018

Hey @Mordax this looks like a really great addition!

My only concern is about the formatting, I gave this a whirl and got:

[warner/magic-wormhole](https://github.com/warner/magic-wormhole) - get things from one computer to another, safelyMain Language: Python
[VulnReproduction/LinuxFlaw](https://github.com/VulnReproduction/LinuxFlaw) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspaceMain Language: C

note the lack of space between the end of the repo description and "Main Language".

The language information looks a bit lonely hanging off the end there, what if we integrated it a bit more by putting it before the description, maybe in some brackets instead of labeling it?

[warner/magic-wormhole](https://github.com/warner/magic-wormhole) (Python) - get things from one computer to another, safely
[VulnReproduction/LinuxFlaw](https://github.com/VulnReproduction/LinuxFlaw) (C) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspace

which, as Markdown, would render like this:

warner/magic-wormhole (Python) - get things from one computer to another, safely
VulnReproduction/LinuxFlaw (C) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspace

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants