feat(workflows): Switch Temporal transfer workflow to intent-first writes #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration Fixes issue where Supabase CLI commands fail outside of Tilt when environment variables from .localnet.env are not loaded. The supabase/config.toml uses env() placeholders for ports: - api.port = "env(SUPABASE_API_PORT)" - db.port = "env(SUPABASE_DB_PORT)" - etc. These require environment variables to be set, otherwise Supabase CLI tries to parse literal strings as port numbers causing errors. Solution: - Update _with-env helper to load .localnet.env (from gen-env) and .env - All supabase commands now use: dotenv -e ../.localnet.env -e ../.env -c -- - Priority: .localnet.env values override .env - Prerequisite: Run `yarn gen-env local --name <workspace>` first Changes: - Update supabase/package.json _with-env helper - Prefix all CLI commands (start, stop, reset, status, etc.) with _with-env Benefits: - Integrates with existing gen-env.ts workflow - Workspace isolation via dynamic ports - Works in any environment (Tilt, CLI, CI) Success criteria: ✅ yarn supabase reset works without parsing errors ✅ Custom ports from gen-env are respected Co-Authored-By: Warp <agent@warp.dev>
Fixes two critical race conditions that occurred when blockchain indexer processes transfers before the Temporal workflow reaches 'confirmed' status: 1. **Notes disappearing**: User notes would be deleted before propagation 2. **Duplicate activities**: Two activities would appear for same transfer Root causes: - Temporal trigger used broad time-based matching to delete activities - No direct FK reference between temporal transfers and pending activities - Indexer could delete temporal activity before note propagation Solution: - Add activity_id column to temporal.send_account_transfers with FK - Create trigger to insert pending activity when status='sent' - Update temporal trigger to propagate notes and delete by exact activity_id - Fix indexer trigger with enhanced matching (user_op_hash + fallback) Changes: - supabase/migrations/20251231_fix_temporal_transfer_race_conditions.sql Consolidated migration with all schema changes in atomic transaction - supabase/schemas/temporal.sql Added activity_id column, new trigger, updated cleanup logic - supabase/schemas/send_account_transfers.sql Enhanced indexer trigger to delete by activity_id with dual matching - packages/workflows/src/transfer-workflow/race-conditions.test.ts Comprehensive test suite (10 tests) covering both race conditions - supabase/tests/temporal_transfers_race_test.sql SQL integration test for race condition scenarios - RACE_CONDITION_FIXES.md Complete documentation with test plan and monitoring queries Test coverage: ✓ Note propagation (3 tests) ✓ Duplicate prevention (5 tests) ✓ Integration scenarios (2 tests) All 25 workflow tests passing Co-Authored-By: Warp <agent@warp.dev>
Implement optimistic navigation that triggers immediately after cache update instead of waiting for temporal workflow to complete. Changes: - Navigate to chat or activity screen immediately after optimistic activity insertion - Move navigation before await transfer() call for instant UX - Keep background workflow for consolidation with temporal/final activity - Existing rollback logic handles workflow failures This builds on race condition fixes in add_activity_id_column_to_temporal_transfers branch which ensure notes propagate correctly and prevent duplicate activities. Benefits: - Instant feedback to user after send action - Temporal workflow consolidates optimistic activity in background - Notes preserved through activity_id FK relationship - Indexer can win race safely with dual matching logic Co-Authored-By: Warp <agent@warp.dev>
…ites - workflow.ts: Creates/updates transfer_intents throughout lifecycle (pending → submitted → confirmed/failed) - activities.ts: Add intent-based activities (upsertTransferIntentActivity, updateTransferIntentActivity, upsertTransferReconciliationActivity) - supabase.ts: Add types and DB functions for transfer_intents and transfer_reconciliations tables - startWorkflow.ts: Add workflowIdOverride parameter for explicit Temporal workflowId (e.g., intent_id UUID) - temporal.ts: Update lookupInitializedWorkflow to check transfer_intents first (intent-first), falling back to activity table (legacy) The workflow now owns intent state instead of relying on public.activity/temporal-trigger side effects. Uses deterministic on-chain identifiers (chain_id, tx_hash, log_idx) for reconciliation. Co-Authored-By: Warp <agent@warp.dev>
|
Vercel Unique URL: https://sendapp-qjn7chskl-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the transfer workflow to use an intent-first write pattern where the workflow owns intent state, replacing the previous approach that relied on
public.activity/temporal-trigger side effects.Changes
Workflow (
packages/workflows/src/transfer-workflow/)workflow.ts: Creates/updates
transfer_intentsthroughout the transfer lifecycle:pending- Intent created at workflow startsubmitted- Updated before sending userOp to chainconfirmed- Updated with tx_hash, block_num, event detailsfailed- Updated with error_message on failureactivities.ts: Added intent-based activities:
getChainIdActivity- Get chain ID for intent trackingupsertTransferIntentActivity- Create/update transfer intentupdateTransferIntentActivity- Update intent status/dataupsertTransferReconciliationActivity- Link intent to on-chain eventsupabase.ts: Added types and database functions:
TransferIntent,TransferIntentInsert,TransferIntentUpdateTransferReconciliation,TransferReconciliationInsertUtilities (
packages/workflows/src/utils/)workflowIdOverrideparameterAPI Layer (
packages/api/src/routers/)lookupInitializedWorkflowfunction:transfer_intentstable (intent-first approach)activitytable for backwards compatibility (legacy)'submitted'to consider workflow startedDeterministic On-Chain Identifiers
The reconciliation uses collision-invariant identifiers:
chain_id- Chain ID for multi-chain supporttx_hash- Transaction hashlog_idx- Log index within transactionThis ensures each on-chain event can only be linked to one intent via UNIQUE constraint.
Testing
This PR was generated with Warp.