feat: deterministic reconciliation + merged activity feed + tests #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement deterministic reconciliation for transfer intents: - Add reconcile_transfer_on_index() trigger using exact tx_hash/user_op_hash matching - Create activity_feed_merged view for unified pending/confirmed transfers - Remove old fuzzy matching (send_account_transfers_delete_temporal_activity) - Add 8 new collision/race invariant tests (total 20 tests) Key invariants enforced: - Two intents with identical (from,to,value) cannot cross-link - Same (chain_id, tx_hash, log_idx) links to exactly one intent - Notes persist regardless of temporal ordering Co-Authored-By: Warp <agent@warp.dev>
|
Vercel Unique URL: https://sendapp-imt3439dv-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements deterministic reconciliation for transfer intents, replacing the old fuzzy matching approach that could cause race conditions and cross-linking issues.
Changes
1. Deterministic Reconciliation Trigger
reconcile_transfer_on_index()function that matches intents by exacttx_hashoruser_op_hashonly(from, to, value)which could cross-link similar transferstransfer_reconciliationsrecord withUNIQUE(chain_id, tx_hash, log_idx)constraint2. Merged Activity Feed View
activity_feed_mergedview that shows:transfer_intents(not yet indexed)3. Removed Fuzzy Matching
send_account_transfers_delete_temporal_activity()functionsend_account_transfers_trigger_delete_temporal_activitytrigger4. Updated Tests
Key Invariants
(from, to, value)will NEVER cross-linkTesting
Run the test suite:
Expected: All 20 tests pass
Migration
The migration will:
This PR was generated with Warp.