Oops #2494
Closed
Oops #2494
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix/sen 164 remove verifying paymaster from deposit (#2260) * fix(earn): remove sendVerifyingPaymasterAddress validation and client override The deposit flow should use tokenPaymasterAddress for gas estimation (which doesn't require a signature). The server will sponsor the operation by signing with sendVerifyingPaymasterAddress regardless of what paymaster the client sends. Changes: - Remove paymaster validation from paymasterSign endpoint (server-side) - Remove sendVerifyingPaymasterAddress override from deposit screen (client-side) - Remove unused sendVerifyingPaymasterAddress import The server always signs with sendVerifyingPaymasterAddress - the client just needs to send a valid operation for gas estimation. Fixes SEN-164 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(earn): restore paymaster address override for Send Earn deposits The previous commit (619811c) incorrectly removed the client-side paymaster override. The correct flow is: 1. useUserOp estimates gas with tokenPaymasterAddress (no signature needed) 2. Server signs with sendVerifyingPaymasterAddress and returns paymasterData 3. Client overrides paymaster to sendVerifyingPaymasterAddress before signing This restores the original working pattern from CDP Bundler (e821219). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> * fix(earn): restore paymaster address override for Send Earn deposits Reset deposit screen to last working state (0bda61f) which correctly overrides the paymaster address after getting paymasterData from server. The flow is: 1. useUserOp estimates gas with tokenPaymasterAddress (no signature needed) 2. Server signs with sendVerifyingPaymasterAddress and returns paymasterData 3. Client overrides paymaster to sendVerifyingPaymasterAddress before signing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Refactor sendpot ticket verification weights Why: Simplifies sendpot_ticket_purchase verification by storing the actual weight value directly in the database instead of requiring custom calculation logic in the distributor. This change improves consistency across all verification types and reduces code complexity. Previous implementation stored ticket BPS in the weight column and required the distributor to convert BPS to ticket count, divide by 10, and multiply by fixed value. This was inconsistent with other verification types which use weight directly. New implementation: - Adds sendpot_ticket_increment column to distributions table (default: 10) - Calculates weight in database: floor(tickets_purchased_count / increment) - Stores raw ticket count in metadata.value for transparency - Removes ~17 lines of custom logic from distributorv2.ts - Makes sendpot_ticket_purchase work like all other verification types Changes: - Database: Added sendpot_ticket_increment column to distributions table - Functions: Updated insert_verification_sendpot_ticket_purchase() trigger and insert_sendpot_ticket_purchase_verifications() batch function to calculate weight using tickets_purchased_count / sendpot_ticket_increment - Metadata: Added 'value' field to store raw ticket count per jackpot period - Distributor: Removed custom sendpot BPS-to-ticket conversion logic, replaced with standard fixedValue * weight calculation - Migration: Created backfill script to update existing verification rows Test plan: - Run yarn supabase migration:diff --check (no schema drift) - Run yarn supabase reset (all 300+ migrations compile successfully) - Verify backfill migration updates existing verifications correctly - Deploy to staging and monitor distributor calculations - Compare distribution shares before/after to ensure parity - Test with various ticket counts (0, 9, 10, 125) to verify weight calculation * Fix schema drift Refactor sendpot ticket verification weights * Account deletion activity impact (#2264) * Account deletion db function and endpoint (#2266) * Add send referral (#2267) * Add send referral * update 2 * update 2 * feat: framer motion as animation driver web (#2265) * feat: new motion driver for web * feat(send): improve sendchat animation * fix(ReferralLink): make its animation to work * feat: improve animation multiple places * fix(CoinsModal): theme dark opacity issue * fix(send): amount input not focusing automatically * feat(motion): make it to support milliseconds instead of seconds * feat(send): improve animation * fix(SendSuggestions): use milliseconds for delay * feat(send): improve performance * [SEN-205] Fix db unit tests detecting active distribution on month split (#2270) * [SEN-170] Fix canton search and top senders to check is_discoverable instead of is_public (#2271) * [SEN-191] Show main tag in referrals screen (#2272) * Deutsch (#2269) * add deutsch locale and config * deutsch resource files --------- Co-authored-by: Big Boss <bigboss@metalrodeo.xyz> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: youngkidwarrior <victor@she.energy> Co-authored-by: Mikołaj Musidłowski <38129890+musidlo@users.noreply.github.com> Co-authored-by: Ehsan sarshar <46188784+byteab@users.noreply.github.com> Co-authored-by: patrick <pathoam@pm.me>
fix: resolve sign-up page overlap and verified badge positioning (#2277)
Fix missed lint error with BigInt conversion
deploy: Add support for external Ethereum addresses in SendChat
Fix avatar check size (#2366)
Send check minor ux fixes (#2370)
Send check metadata (#2373)
Update SEO Metadata
Add icon for claimed/invalid send checks message & Fix retry (#2392)
fix security invoker bug (#2504)
fix inverted for analytics service(#2512)
Coingecko cache proxy (#2527)
refactor(bank-transfer): display bank_address instead of beneficiary …
Business onboarding improvements (#2547)
Fix missing migration for vba (#2549)
Revert Portal for bottom navbar in native app
fix(localnet): resolve docker compose networking issues (#2572)
Playwright Report
Summary
Suites✅ account-sendtag-add.onboarded.spec.ts (5/5 passed)can visit add sendtags page
can add a pending tag
cannot add an invalid tag name
cannot add more than 5 tags
cannot confirm a tag without paying
❌ account-sendtag-checkout.onboarded.spec.ts (0/3 passed)can confirm a tag
can refer a tag
can refer multiple tags in separate transactions
❌ account-settings-backup.onboarded.spec.ts (0/2 passed)can backup account
can remove a signer
✅ account.logged-in.spec.ts (2/2 passed)can visit account page
can update profile
❌ activity.onboarded.spec.ts (0/1 passed)can visit activity page and see correct activity feed
✅ contacts.onboarded.spec.ts (0/0 passed)✅ earn.onboarded.spec.ts (0/0 passed)✅ home.onboarded.spec.ts (1/1 passed)can visit token detail page
✅ leaderboard.logged-in.spec.ts (0/0 passed)can visit leaderboard page
✅ onboarding.logged-in.spec.ts (1/1 passed)can visit onboarding page
✅ profile-external-address.anon.spec.ts (0/0 passed)✅ profile-external-address.onboarded.spec.ts (0/0 passed)❌ profile.anon.spec.ts (1/2 passed)anon user can visit public profile
anon user cannot visit private profile
❌ profile.logged-in.spec.ts (0/1 passed)logged in user needs onboarding before visiting profile
✅ profile.onboarded.spec.ts (4/4 passed)can visit other user profile and send by tag
can visit my own profile
can visit private profile
can view activities between another profile
❌ send-token-upgrade.onboarded.spec.ts (0/1 passed)can upgrade their Send Token V0 to Send Token V1
❌ send.onboarded.spec.ts (0/13 passed)can send USDC starting from profile page
can send USDC using tag starting from home page
can send USDC using sendid starting from home page
can send USDC using address starting from home page
can send SEND starting from profile page
can send SEND using tag starting from home page
can send SEND using sendid starting from home page
can send SEND using address starting from home page
can send ETH starting from profile page
can send ETH using tag starting from home page
can send ETH using sendid starting from home page
can send ETH using address starting from home page
cannot send below minimum amount for SEND token
❌ sendtag-happy-path.onboarded.spec.ts (0/1 passed)sendtag complete happy path - create, confirm, and change main tag
sendtag main tag succession - auto-assigns new main when current is deleted
✅ sign-in.anon.spec.ts (3/3 passed)redirect on sign-in
redirect to send page on sign-in with recipient params
old user can login using phone number
✅ sign-up.anon.spec.ts (2/2 passed)can sign up
country code is selected based on geoip
❌ swap.onboarded.spec.ts (2/5 passed)can swap USDC for SEND
can swap USDC for ETH
can refresh swap form and preserve filled data
can't access form page without accepting risk dialog
can't access summary page without filling swap form
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
If you ended up here. You probably did something stupid like try to merge main into dev.
fysi