feat/notification-api #2578
Open
feat/notification-api #2578
+3,048
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created `feat/notification-api` branch with the notification preferences API endpoint (`apps/next/pages/api/notifications/preferences.ts`) as an atomic branch. Successfully split this API file from the larger commit in `create-branch4`/`feat/notification-constants` following the review recommendations. Co-Authored-By: Warp <agent@warp.dev>
- Return null for unknown notification types instead of casting - Add coerceNumber helper to handle string-encoded numeric values in push payloads - Fix sendId and reward field parsing to accept both numbers and numeric strings Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jan 18, 2026
Open
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 18, 2026
Playwright Test ResultsNo test results availableNo test results were found. This could be because tests failed to run or artifacts were not uploaded. |
|
Vercel Unique URL: https://sendapp-efek81kx7-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create branch4
Created
feat/notification-apibranch with the notification preferences API endpoint (apps/next/pages/api/notifications/preferences.ts) as an atomic branch. Successfully split this API file from the larger commit increate-branch4/feat/notification-constantsfollowing the review recommendations.Co-Authored-By: Warp agent@warp.dev
fix: tighten parseNotificationData validation and coerce numeric fields
Co-Authored-By: Claude noreply@anthropic.com