Conversation
|
Merging to
|
sapta100ms
reviewed
Oct 24, 2025
| import org.devio.rn.splashscreen.SplashScreenReactPackage; | ||
|
|
||
| public class MainApplication extends Application implements ReactApplication { | ||
| public class MainApplication extends MultiDexApplication implements ReactApplication { |
There was a problem hiding this comment.
Not sure if we need MultiDexApplication since our min API version is 24.
ygit
changed the title
- Update React from 17.0.1 to 18.2.0 in react-native-hms - Update build workflows to use Java 17 and Node 22.20.0 - Add --legacy-peer-deps flags for npm install - Upgrade trunk-action to v1.1.16 (fixes deprecated artifact action) - Make Vale linter non-blocking temporarily - Regenerate package-lock.json with updated dependencies
.nvmrc file is not committed to the repo (in global gitignore), so GitHub Actions cannot read it. Using explicit version instead.
- Update react-native peerDependency from >=0.64.0 to >=0.73.0 - Update README.md minimum and recommended configurations: - React Native: 0.73.0+ min, 0.77.3 recommended - Java: 17+ (was 8/11) - Node.js: 18+ min, 22+ recommended - iOS: 16.0+ (was 12.0) - Android: API 24+ with 64-bit only architectures - Update CLAUDE.md with new version requirements - Reflect changes made in RN 0.77.3 upgrade (PR #1509) - Removes support for 32-bit Android architectures
- Upgrade trunk-action from v1.1.16 to v1.2.4 - Fixes deprecated actions/upload-artifact@v3 error - v1.2.4 uses upload-artifact@v4 - Remove 'Vocab = HMSVocab' from .vale.ini - Vale 3.x expects vocabularies at config/vocabularies/ path - Repo has vocab at .github/styles/Vocab/ (old location) - Removing vocab config to fix runtime error Fixes trunk-check and vale-linter workflow failures
- Fix AnimatedStyleProp type usage in keyboard avoiding views - Allow both AnimatedStyleProp and StyleProp for style props - Update dependencies to fix security vulnerabilities (npm audit fix) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the React Native SDK from 0.71.19 to 0.77.3 and implements Android 16KB page size compliance required for Google Play in 2025.
Major Changes
Core Upgrades
Android Modernization
iOS Modernization
Dependency Updates
Build Performance
Breaking Changes
16KB Page Size Status
While the app runs correctly on 16KB devices in compatibility mode, native libraries are not yet 16KB-aligned due to current AGP/bundletool limitations. See
android/16KB_PAGE_SIZE_FINDINGS.mdfor detailed investigation. Full compliance expected when uploading AAB to Play Store.Testing
Related Documentation
packages/react-native-room-kit/example/ExampleAppChangelog.txt