Open
Conversation
|
Thanks for the PR, i'll review it ASAP. I'm planning to do another release soon. There have been some interesting developments in the Carthage community. |
|
Are you planning to submit a PR for RomeKit as well? Because ideally we get that merged before this one. |
Author
|
Already submitted to RomeKit, RomeCLI and homebrew tap (don't merge it, simply use as reference) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for additional Carthage arguments.
You can call RomeBuild like this
romebuild --build --platform ios -- --color always --derived-data buildYou can put
--to the end of the command and put any additional arguments for Carthage after.Arguments filtered by the table(Added to Carthage.swift). Only supported arguments will be sent to the Carthage command calls