Potential Fix for Joysticks on New Versions of Chrome#16
Open
ExploitSage wants to merge 3 commits into221robotics:masterfrom
Open
Potential Fix for Joysticks on New Versions of Chrome#16ExploitSage wants to merge 3 commits into221robotics:masterfrom
ExploitSage wants to merge 3 commits into221robotics:masterfrom
Conversation
Contributor
Author
|
I should modify this to handle both |
Member
|
Excellent work. We’ll review and get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still warrants more testing as I only had one XBox 360 Clone controller to test with, but what I was able to test works beautifully. I also haven't been able to test Chrome 53 since that is officially being recommended, as I don't have a Windows machine handy.
Not sure if there were previous issues that have since been resolved, but it looks like the issue here is that somewhere along the way, "empty" joysticks went from being
undefinedtonullin the array returned bynavigator.getGamepads(). Unfortunatelytypeof nullis'object'as is the type of an actual Gamepad object, so no changes to the array were being processed. I have re-worked the logic to use true/false and check explicitly for null. Possible this could break again in the future I guess, but it does seem to work now.fix #15