refactor: rename simmit module to _core and cleanup legacy naming #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the internal C++ module from `simmit` to `_core`, following Python conventions for internal extension modules. Also rename the wrapper source file from the legacy Boost.Python name. Changes: - Rename boostpython_smartplus_wrappers.cpp to python_module.cpp - Rename CMake target from simmit to _core - Update PYBIND11_MODULE declaration to use _core - Update __init__.py to import from _core - Add backward compatibility alias for existing `from simcoon import simmit` - Update legacy install scripts (Install.sh, Install.bat) Closes #53
- Rename solver.py.py to solver.py - Rename simmit_test directory to test_core - Remove boost dependency from conda.recipe/meta.yaml - Update test import to use _core instead of simmit - Remove outdated boost references from documentation - Update install scripts and READMEs
Update imports, documentation, and code references to use the new module structure where functions are exported at the simcoon level. Changes: - Update test imports from `from simcoon import simmit` to `from simcoon import _core` - Update example/tutorial imports to `import simcoon as sim` - Update notebook imports to `import simcoon as sim` - Update RST documentation autofunction references from simcoon.simmit to simcoon - Update C++ docstrings in doc_hyperelastic.hpp - Update CLAUDE.md to reference _core module - Update CMakeLists.txt comment - Update Install.sh commented install_name_tool paths
- Update conda-packaging.yml to check for _core.so instead of simmit.so - Clear notebook output containing old error messages
Deleted various input and output data files from Mechanical and Thermomechanical Umats notebook directories. This cleanup likely removes obsolete or unnecessary test data to reduce repository size or prepare for new data generation.
This reverts commit 5d48cd1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
simmitto_corefollowing Python conventions for internal extension modulesboostpython_smartplus_wrappers.cpptopython_module.cppimport simcoon as sim)from simcoon import simmitChanges
Core module rename
simcoon-python-builder/src/python_wrappers/python_module.cpp: Renamed fromboostpython_smartplus_wrappers.cpp, updatedPYBIND11_MODULE(_core, m)simcoon-python-builder/CMakeLists.txt: Updated target name fromsimmitto_corepython-setup/simcoon/__init__.py: Import from_core, addsimmitalias for backward compatibilityLegacy cleanup
python-setup/simcoon/solver.py: Renamed fromsolver.py.pysimcoon-python-builder/test/test_core/: Renamed fromsimmit_test/simcoon-python-builder/cmake/README.txt: Removed outdated boost.python referencesconda.recipe/meta.yaml: Removed boost dependencyinstall_conda.md: Removed boost install step, updated file referencesInstall.sh,Install.bat: Updated file references, removed boostDocumentation & examples updates (55 files)
from simcoon import simmit as simtoimport simcoon as sim.. autofunction::references fromsimcoon.simmit.Xtosimcoon.Xdoc_hyperelastic.hppTesting
import simcoonworksfrom simcoon import simmitworks (backward compatibility)from simcoon import _coreworksRelated Issue
Closes #53