Conversation
| @@ -0,0 +1,4 @@ | |||
| global: | |||
| scrape_interval: 10s | |||
| scrape_timeout: 5s | |||
There was a problem hiding this comment.
These seem a bit aggressive to me. Do we need near real-time metrics for our use cases? Can we scrape every 30 seconds to a minute?
There was a problem hiding this comment.
I just pulled these setting along from the existing config.
Want to drop them down to the defaults?
# How frequently to scrape targets by default.
[ scrape_interval: [<duration>](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#duration) | default = 1m ]
# How long until a scrape request times out.
[ scrape_timeout: [<duration>](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#duration) | default = 10s ]
There was a problem hiding this comment.
If we don't have a reason to scrape aggressively then we can save resources by setting defaults
| action: replace | ||
| target_label: kubernetes_container | ||
|
|
||
| processors: |
There was a problem hiding this comment.
Can we filter out duplicates while processing?
There was a problem hiding this comment.
We can if necessary, see this issue about the situation.
samika98
left a comment
samika98
left a comment
There was a problem hiding this comment.
Looks good to me! Have a questions/concerns about having both push and pull based metrics in the system
3 participants
Prometheus doesn't scrape anything now, it is pushed from opentelemetry.
This should reduce duplicate metrics and provide a single collector to forward to different exporters as required.