adding data-name="$post->post_name" for more symantic js if needed#3
Open
dannyb195 wants to merge 1 commit into3themes:masterfrom
Open
adding data-name="$post->post_name" for more symantic js if needed#3dannyb195 wants to merge 1 commit into3themes:masterfrom
dannyb195 wants to merge 1 commit into3themes:masterfrom
Conversation
Member
|
Dan, I LOVE this idea, and am adding it to a site I'm working on now, but it violates our "only if absolutely necessary" rule about functionality for our vanilla theme. You know what would be AWESOME, though? This as a plugin. I could see a plugin with a checkbox list where you turn on data-* attributes, like data-title, data-id, data-position-on-page, data-author, data-author-id, data-categories, data-date-published, and more (cant think of any more right now). I've added a universal-plugins repo. Want to play with that idea? Just fork it, add a folder for the plugin, and code away. We can all add as we think of some that would be useful sometime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$post->post_name = slug (most of the time as far as I can tell)