-
Notifications
You must be signed in to change notification settings - Fork 7
#215 Prevent mapping of inaccessible fields to record #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#215 Prevent mapping of inaccessible fields to record #217
Conversation
marcustalbot-ov
commented
Oct 30, 2025
- Fixed bug where inaccessible fields (usually private fields without accessor) would be mapped to a target record, disregarding mapping rules.
646a3c6 to
6cc0362
Compare
|
The Codacy analysis only flags the 'unused' private fields in the test-classes. As such, I recommend ignoring those issues. |
7c3df88 to
02631a4
Compare
|
1 test failure |
|
Fixing the pipeline is not something I can do easily. Steps to fix the problem can be found here: https://rieckpil.de/fix-sonatype-oss-index-errors-for-owasp-maven-plugin/ Unless setting the ossindexAnalyzerEnabled-flag to false is acceptable. In that case, please let me know. Or, if you were talking about a test-failure in the library itself, could you tell me what is failing? It runs on my machine, with Java 21. |
|
Library tests run successfully for java 21, but when running with the recently added java 25 this results in an IllegalArgumentException for testMapEntityWithMapToEntityResultWithMap. |
- Fixed bug where inaccessible fields (usually private fields without accessor) would be mapped to a target record, disregarding mapping rules. Signed-off-by: Marcus Talbot <marcus.talbot@openvalue.nl>
02631a4 to
c26bf49
Compare
|
That's a known issue, which was fixed in the latest merged PR. I have now rebased this branch to include the fix. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
============================================
- Coverage 87.61% 86.24% -1.38%
- Complexity 998 1169 +171
============================================
Files 110 129 +19
Lines 2205 2603 +398
Branches 246 298 +52
============================================
+ Hits 1932 2245 +313
- Misses 183 230 +47
- Partials 90 128 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
While the OWASP Dependency Check succeeds, the logs contain the following warning:
Ideally, authentication is arranged for the OSS Index Analyzer. |


