Skip to content

Added missing includes (for uintmax_t, ofstream)#70

Open
Teeed wants to merge 1 commit into45Drives:masterfrom
Teeed:master
Open

Added missing includes (for uintmax_t, ofstream)#70
Teeed wants to merge 1 commit into45Drives:masterfrom
Teeed:master

Conversation

@Teeed
Copy link

@Teeed Teeed commented Feb 11, 2024

Platform:
arch linux (up-to-date @ 12.02.2024), gcc version 13.2.1 20230801 (GCC)

Fixes following compilation errors:

In file included from src/impl/autotierfs/conflicts.cpp:20:
src/incl/alert.hpp:96:34: error: ‘uintmax_t’ has not been declared
   96 |         std::string format_bytes(uintmax_t bytes) const;
      |                                  ^~~~~~~~~
src/incl/alert.hpp:107:29: error: ‘uintmax_t’ has not been declared
  107 |         double format_bytes(uintmax_t bytes, std::string &unit) const;
      |                             ^~~~~~~~~

and

src/impl/autotierfs/config.cpp:228:25: error: variable ‘std::ofstream f’ has initializer but incomplete type
  228 |         std::ofstream f(config_path.string());

@Teeed Teeed changed the title Added missing includes (fot uintmax_t Added missing includes (fot uintmax_t, ofstream) Feb 11, 2024
@Teeed Teeed changed the title Added missing includes (fot uintmax_t, ofstream) Added missing includes (for uintmax_t, ofstream) Feb 12, 2024
@TheLinuxGuy
Copy link

I'm shocked that this PR from 2024 hasn't even been reviewed by the 45drives team at all a year later....

@philipwilk
Copy link

philipwilk commented Feb 9, 2025

There's some <list>s missing as well
1f97703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants