add possibility to hide INTERNAL marked properties #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladtepesch
commented
Dec 22, 2025
| | PROPERTY_USAGE_GROUP | ||
| | PROPERTY_USAGE_SUBGROUP | ||
| | PROPERTY_USAGE_SCRIPT_VARIABLE | ||
| | PROPERTY_USAGE_INTERNAL): |
Author
There was a problem hiding this comment.
I would tend to not include the PROPERTY_USAGE_INTERNAL flag in the default (and hide by default) but I wanted to not change the current behaviour
4d49
requested changes
Dec 23, 2025
| return false | ||
|
|
||
| # ignore internal marked properties if not enabled to include them | ||
| if (usage & PROPERTY_USAGE_INTERNAL) and not (usage_flags & PROPERTY_USAGE_INTERNAL): |
Owner
There was a problem hiding this comment.
Suggested change
| if (usage & PROPERTY_USAGE_INTERNAL) and not (usage_flags & PROPERTY_USAGE_INTERNAL): | |
| if usage & PROPERTY_USAGE_INTERNAL and not (usage_flags & PROPERTY_USAGE_INTERNAL): |
| if usage_flags & PROPERTY_USAGE_EDITOR and not (usage & PROPERTY_USAGE_EDITOR): | ||
| return false | ||
|
|
||
| # ignore internal marked properties if not enabled to include them |
Owner
There was a problem hiding this comment.
Suggested change
| # ignore internal marked properties if not enabled to include them | |
| # Ignore internal marked properties if not enabled to include them |
Comment on lines
+30
to
+35
| ) var usage_flags: int = ( PROPERTY_USAGE_EDITOR | ||
| | PROPERTY_USAGE_CATEGORY | ||
| | PROPERTY_USAGE_GROUP | ||
| | PROPERTY_USAGE_SUBGROUP | ||
| | PROPERTY_USAGE_SCRIPT_VARIABLE | ||
| | PROPERTY_USAGE_INTERNAL): |
Owner
There was a problem hiding this comment.
Suggested change
| ) var usage_flags: int = ( PROPERTY_USAGE_EDITOR | |
| | PROPERTY_USAGE_CATEGORY | |
| | PROPERTY_USAGE_GROUP | |
| | PROPERTY_USAGE_SUBGROUP | |
| | PROPERTY_USAGE_SCRIPT_VARIABLE | |
| | PROPERTY_USAGE_INTERNAL): | |
| ) var usage_flags: int = var usage_flags: int = PROPERTY_USAGE_EDITOR | PROPERTY_USAGE_CATEGORY | PROPERTY_USAGE_GROUP | PROPERTY_USAGE_SUBGROUP | PROPERTY_USAGE_SCRIPT_VARIABLE: |
We have to leave the old behavior. PROPERTY_USAGE_INTERNAL should remain disabled by default.
Author
There was a problem hiding this comment.
We have to leave the old behavior. PROPERTY_USAGE_INTERNAL should remain disabled by default.
but then the flag has to be enabled by default as in my proposal (see my above comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properties that are exported with the
PROPERTY_USAGE_INTERNALcan be hidden by removing the newly added flag (default=on - to mimik current behaviour) :this implements the simple solution of #37