Open
Conversation
yurisim
reviewed
Aug 30, 2021
| return default; | ||
| bool valid = false; | ||
|
|
||
| try |
Member
There was a problem hiding this comment.
Was surprised to see a try-catch! However, a try-parse @ line 24 will work just the same.
yurisim
reviewed
Aug 30, 2021
| { | ||
|
|
||
|
|
||
| List<int> list = hyphenNum.Split('-').Select(p => int.Parse(p)).ToList(); |
Member
There was a problem hiding this comment.
You can instead do
Suggested change
| List<int> list = hyphenNum.Split('-').Select(p => int.Parse(p)).ToList(); | |
| List<int> list = hyphenNum.Split('-').Select(int.Parse).ToList(); |
when using single character wheres and selects.
For example, can use someString.Where(char.IsNumber) without having to do the lambda expression
yurisim
reviewed
Aug 30, 2021
|
|
||
| DateTime dt; | ||
|
|
||
| if (DateTime.TryParseExact(hyphenNum, format, invariant, DateTimeStyles.None, out dt)) |
Member
There was a problem hiding this comment.
Suggested change
| if (DateTime.TryParseExact(hyphenNum, format, invariant, DateTimeStyles.None, out dt)) | |
| return (DateTime.TryParseExact(hyphenNum, format, invariant, DateTimeStyles.None, out dt)) |
yurisim
reviewed
Aug 30, 2021
| } | ||
| else | ||
| { | ||
| oneWord = System.Threading.Thread.CurrentThread.CurrentCulture.TextInfo.ToTitleCase(aFewWords.Trim().ToLower()); |
Member
There was a problem hiding this comment.
Was expecting a split instead of ToTitleCast
But this also works.
yurisim
reviewed
Aug 30, 2021
|
|
||
| for(int i = 0; i < aWord.Length; i++) | ||
| { | ||
| if (aWord[i] == 'a' || aWord[i] == 'e'|| aWord[i] == 'i'|| aWord[i] == 'o' || aWord[i] == 'u'|| |
Member
There was a problem hiding this comment.
Use .Contains instead of this OR statement.
Also toLower (or toUpper) the input so that you only need to worry about one case of vowels instead of both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.