Added all 2014 and 2024 feats #824
Conversation
| @@ -1,4 +1,130 @@ | |||
| [ | |||
| { | |||
| "index": "actor", | |||
There was a problem hiding this comment.
Many of these feats are not in the SRD, so we cannot include them. Check our FAQ for more info about the SRD.
The only Feat in the 2014 SRD is "Grappler", and SRD 5.2 (2024) includes the origin feats Alert, Magic Initiate, Savage Attacker, and the general feat Grappler.
| "General Feat", | ||
| "Increase one ability score of your choice by 2, or increase two ability scores of your choice by 1. This feat can't increase an ability score above 20.", | ||
| "**Repeatable**. You can take this feat more than once.", | ||
| "PREREQ: level = 4" |
There was a problem hiding this comment.
Same here. We should be using the prerequisites array.
| "name": "Ability Score Improvement", | ||
| "prerequisites": [], | ||
| "desc": [ | ||
| "General Feat", |
There was a problem hiding this comment.
What purpose does this serve? The SRD doesn't contain this text in the Feat description.
We probably need to add a feat_type field to differentiate Origin, General, Fighting Style and Epic Boon Feats..
There was a problem hiding this comment.
I'm aware that you mention this in your PR description, but we should probably be designing this data nicely all in one go, rather than breaking it into lots of PRs.
2 participants
What does this do?
I've added all of the 2014 and 2024 feats to the JSON files. Please note, the feats class was only setup to display ability score prerequisites. the 2014 feats also has spellcasting and armor training prerequisites, and 2024 has those as well as level prereqs. Because there was no plase to add those, I simply added them to the bottom of the description. I will create a feature request to add those also. Once it is ready, I can easily go back update the JSON files to include those.
How was it tested?
I ran
npm run testand all tests passed.Is there a Github issue this is resolving?
No
Did you update the docs in the API? Please link an associated PR if applicable.
No
Here's a fun image for your troubles