Open
Conversation
Owner
8ball030
commented
Jan 27, 2025
8ball030
commented
- feat/moved-to-services
- refactor:moved-to-new-service
- refactor:implemented-base-class
- refactor:implemented-simple-tests
- feat:service-attempts-to-start
- feat/moved-to-services
kevoconnell
reviewed
Jan 27, 2025
Comment on lines
26
to
29
| TENDERMINT_RESET_TIMEOUT = 10 | ||
| TENDERMINT_RESET_ENDPOINT = "http://localhost:8080/hard_reset" | ||
| TENDERMINT_RESET_RETRIES = 20 | ||
|
|
Collaborator
There was a problem hiding this comment.
these should be constants prob
Comment on lines
32
to
36
| def with_spinner(): | ||
| """Context manager to show spinner.""" | ||
| console = rich.get_console() | ||
| with console.status("Please wait...", spinner="aesthetic"): | ||
| yield |
Collaborator
There was a problem hiding this comment.
i like this, i wonder if it could be globally accessed
Comment on lines
83
to
88
| ) -> None: | ||
| """Run an agent in production mode. | ||
|
|
||
| Example usage: | ||
| adev run prod eightballer/my_service | ||
| """ |
Collaborator
There was a problem hiding this comment.
can we include the params in this docstring - the docs will fail if not (can also do later lol)
Comment on lines
255
to
265
| self.logger.exception(f"Failed to start Tendermint: {e!s}") | ||
|
|
||
| msg = dedent(""" | ||
| Please check that: | ||
| 1. Docker is installed and running | ||
| 2. Docker compose is installed | ||
| 3. You have necessary permissions to run Docker commands | ||
| 4. The Tendermint configuration file exists and is valid | ||
| """) | ||
| self.logger.exception(msg) | ||
| sys.exit(1) |
Collaborator
There was a problem hiding this comment.
there prob should be a docker error type
This was referenced Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.