Open
Conversation
8ball030
reviewed
Mar 13, 2025
8ball030
reviewed
Mar 14, 2025
| import signal | ||
| import tempfile | ||
| from pathlib import Path | ||
| from contextlib import chdir, contextmanager |
Owner
There was a problem hiding this comment.
is it possible to not use this chidr?
iirc os.chdir can be used as a context as well, and then it means we dont drop an entire python version
8ball030
reviewed
Mar 14, 2025
| raise ValueError(msg) | ||
|
|
||
| with isolated_filesystem(): | ||
| with rollback.on_exception(Path.cwd()): |
Owner
There was a problem hiding this comment.
this is gonna be great,
Only issue i can foresee is that currently, we use sys.exit(1) such that we exit from the cli.
Id like to basically raise exceptions and then handle them in the cli code with a sys.exit
That makes the output from the tool look a lot nicer as then we dont have like the stack trace every time it throws if that makes sense.
Owner
|
Please consider pr; I believe this lets us keep 3.10 for just a little while longer (Assuming she passes ci) |
This was referenced Apr 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #609