Conversation
Owner
8ball030
commented
Sep 11, 2025
8ball030
commented
- feat: added private endpoints in base_client.py feat: implemented logic for transfer_position & transfer_positions in endpoints.py chore: bumped derive-action-signing version to latest 0.0.13
- feat: cli method updated to support transfer_position & positions endpoints
- fix: made the suggested changes
- fix: removed the check for position_amount
- feat: examples & tests added for the new transfer_position/s endpoints
- fix: merged conflicts fixed
- fix: fixed flake8 errors
- feat: Update position_setup fixture to dynamically fetch instruments and fix position amount issues
- fix: proper tests added to first open a position, transfer it then trasnfer back to the original account then close it
- fix: fixed the tranfer_position & positions methods. Earlier they were using only the ETH-Perps & transfer_positions was using TRADE_MODULE instead of RFQ
- feat: new fixtures added & new tests added
- feat: all tests are green now. Updated the base_client to handle the transfers
- feat: RFQ_MODULE address added in the ContractAddresses class
- feat: minor fixes & examples updated for transfer_position & transfer_positions
- feat: import fixed in cli.py
- fix: linter issues
- feat: Order model
- feat: Trade model
- feat: Quote model
- feat: PositionTransfer and PositionsTransfer
- fix: remove derive_client_2 and update tests
- chore: remove _extract_transaction_id
- fix: test_single_position_transfer
- chore: cleanup conftest
- fix: test_funding_transfers.py
- fix: remove subaccount_id attribute assignment in cliet fixtures
- fix: transfer_position
- feat: assign subaccount_ids as attribute on client instantiation
- feat: PositionSpec
- chore: outcomment problematic ARBITRUM endpoints
- fix: transfer_positions WIP
- feat: get_order endpoint
- chore: add outcommented session key wallet address to conftest
- tests: test_transfer_positions WIP
- fix:ensures-position-orders-fill
- fix:disable-simultaneous-test
- chore:remove-non-working-json-loader
- feat:enabled-other-test
3 tasks
8ball030
commented
Sep 13, 2025
tests/test_rfq.py
Outdated
|
|
||
| @dataclass | ||
| class Leg: | ||
| class Leg(BaseModel): |
| subaccount_id: str | ||
| leg_1: Leg | ||
| leg_2: Leg | ||
| class Rfq(BaseModel): |
Owner
Author
There was a problem hiding this comment.
Should be types or models not in tests
Collaborator
There was a problem hiding this comment.
will address models in subsequent PR
Merge pull request #86 from 8ball030/feat/ruff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.