Conversation
AtomicFS
added
feature
AtomicFS
force-pushed
the
feat/package_cleanup
branch
5 times, most recently
from
1837675 to
7442a30
Compare
AtomicFS
changed the title
AtomicFS
force-pushed
the
feat/package_cleanup
branch
2 times, most recently
from
d08a2ca to
4d9d50d
Compare
Collaborator
Author
|
As far as the dry-run goes, it seems to do exactly what we want. https://github.com/9elements/firmware-action/actions/runs/8082835550/job/22084531761#step:2:62 |
Collaborator
Author
|
FYI there are many versions right now. Most of them are useless. Untagged can be deleted right-away. Tagged, I would only keep the most important ones.
|
AtomicFS
force-pushed
the
feat/package_cleanup
branch
from
4d9d50d to
8e7c64c
Compare
MDr164
reviewed
Mar 1, 2024
Collaborator
MDr164
left a comment
MDr164
left a comment
There was a problem hiding this comment.
Looks good. Should we note somewhere inside the yaml why the fork was necessary? Maybe link the PRs or issues from upstream so we can hopefully switch back to upstream at some point.
Collaborator
Author
|
Yeah, that is a good idea. |
AtomicFS
force-pushed
the
feat/package_cleanup
branch
from
8e7c64c to
05f2d97
Compare
MDr164
approved these changes
Mar 4, 2024
Collaborator
MDr164
left a comment
MDr164
left a comment
There was a problem hiding this comment.
Looks good, let's hope dry-run worked the way it was intended. :D
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
Needs to be rebased on top of #161 to satisfy merge queue again |
- add a step in docker-build-and-test to delete old published containers - should delete all but 'main', 'latest' and release containers - we have to use my own fork of actions/delete-package-versions at the moment to have access to 'dry-run' and 'ignore-versions-include-tags' features - [dry-run](https://github.com/actions/delete-package-versions/pull/119/commits) - [tags](actions/delete-package-versions#104) Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
force-pushed
the
feat/package_cleanup
branch
from
05f2d97 to
c169a50
Compare
Collaborator
Author
|
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/delete-package-versionsat the moment to have access todry-runandignore-versions-include-tagsfeaturesFixes #135