Skip to content

MultiContrast object addition #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sangyu wants to merge 8 commits into from
Closed

MultiContrast object addition #209

sangyu wants to merge 8 commits into from

Conversation

@sangyu
Copy link
Collaborator

@sangyu sangyu commented Aug 25, 2025

Addition of MultiContrast Object

  1. Adding a multi.ipynb (including MultiContrast object construction, data checking, plotting methods).
  2. Combines multiple dabest objects that are arranged in a list into a MultiContrast object. Supports 1D and 2D arrangements.
  3. Includes data validation mostly from current dabest.forest_plot
  4. Includes 2 plotting methods: vortexmap and forest_plot, supports plotting both types from mc object. In the case of plotting MultiContrast.forest_plot(), original forest_plot is called.
  5. Current forest plot syntax unchanged. TODO: consider downstream integration
  6. TODO: add unit test

Addition of multicontrast.ipynb

  1. Includes usage docs for the functions.

JAnns98 and others added 8 commits March 27, 2025 15:18
@JAnns98
Merge pull request ACCLAB#205 from ACCLAB/v2025.03.27
c9c2e83 
Merge v2025.03.27 into master branch
@JAnns98
Merge pull request ACCLAB#206 from ACCLAB/vnbdev
5d83bb1 
Updated changelog and about page
@sangyu
initial commit for vortexmap and tutorial
9ca8aa1
@sangyu
added vortexmap 2d functionality
a293e89 
Constructing MultiContrast class with a 2d array in the form of a nested list now works to produce a 2d vortexmap.
@sangyu
delete old vortexmap file
770798b
@sangyu
Integration with Forest plot
a9829b7 
1. multi.ipynb was re-written to enable integration with forest_plot.
* MultiContrast (mc) object data loading now incorporates Jonny's thorough data validations from forest_plot()
* mc object now has a method forest_plot() that plots a forest_plot from 1-D mc objects using existing forest_plot code.
2. 10-multicontrast.ipynb tutorial edited accordingly.
TODO: add unit test for mc
@sangyu
Update README.md
9e08d9f
@sangyu
Merge pull request #1 from sangyu/master
5a1eeed 
putting multi contrast commits into rebased vnbdev branch
@review-notebook-app
Copy link

review-notebook-app bot commented Aug 25, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@sangyu
Copy link
Collaborator Author

sangyu commented Aug 25, 2025

Meant to say that current forest plot code and usage remain unchanged.

@sangyu sangyu assigned sangyu and JAnns98 and unassigned sangyu Aug 25, 2025
@sangyu sangyu closed this Aug 26, 2025
@sangyu sangyu deleted the vnbdev branch August 26, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JAnns98 JAnns98

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sangyu @JAnns98