Make the python writers have the same behavior as the C++ writers #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
approved these changes
Dec 4, 2025
If no collections are passed then let the C++ decide instead of passing all collections (which is what the C++ writers do). In practice, this only allows to write empty frames from python, currently not possible as collections will evaluate to false and all the collections from `frame.getAvailableCollections` will be passed.
tmadlener
force-pushed
the
same-behaviour
branch
from
816e0fb to
da403f6
Compare
Contributor
|
Should this have a test to check this behaviour? Perhaps in longer future python reading and writing could be rewritten to use C++ (type-erased) readers/writers with less wrappers? |
Collaborator
Yes, it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
If no collections are passed then let the C++ decide instead of passing all collections (which is what the C++ writers do). In practice, this only allows to write frames with no collections from python, currently not possible as collections will evaluate to false and all the collections from
frame.getAvailableCollectionswill be passed.