Open
Conversation
…tron-mlflow-status
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves MLflow run termination handling for Megatron training by ensuring runs are explicitly ended with proper terminal statuses and termination reasons, rather than being left in an active state.
Changes:
- Added
end_mlflow_run()helper function to terminate MLflow runs with explicit status (FINISHED/FAILED/KILLED) and termination reason tags - Wrapped main training logic in try-except-finally blocks to handle normal completion, early exits (SystemExit), keyboard interrupts, and exceptions
- Replaced implicit MLflow termination calls with explicit status-aware termination
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| primus/backends/megatron/training/global_vars.py | Added end_mlflow_run() helper function to centralize MLflow run termination with explicit status and reason tags |
| primus/modules/trainer/megatron/trainer.py | Added exception handling in run() method to capture training outcomes and call end_mlflow_run() with appropriate status; updated early-exit path to use new termination helper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve MLflow run termination reporting for Megatron training so the MLflow UI reflects the correct final status and a helpful termination reason.
What changed
Notes
MLflow termination updates are emitted only from the designated MLflow rank to avoid multi-rank contention.