Skip to content

Support for PEtab SciML in jax#2614

Merged
FFroehlich merged 118 commits intomainfrom
jax_sciml
Nov 1, 2025
Merged

Support for PEtab SciML in jax#2614
FFroehlich merged 118 commits intomainfrom
jax_sciml

Conversation

@FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Dec 2, 2024

CI

  • turn testcase runner into proper pytest
  • add github workflow

neural nets

  • fix non-passing networks tests involving convolutional layers (004-008, 021, 022, 046 - 048, 050)

amici core

tests

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

❌ Patch coverage is 91.30435% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.73%. Comparing base (4e87d9c) to head (675cee9).
⚠️ Report is 99 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/jax/petab.py 86.86% 18 Missing ⚠️
python/sdist/amici/de_model.py 89.28% 6 Missing ⚠️
python/sdist/amici/jax/nn.py 94.82% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
+ Coverage   76.51%   76.73%   +0.21%     
==========================================
  Files         308      309       +1     
  Lines       19548    19884     +336     
  Branches     1500     1498       -2     
==========================================
+ Hits        14958    15258     +300     
- Misses       4577     4613      +36     
  Partials       13       13              
Flag Coverage Δ
cpp 72.55% <54.49%> (-0.37%) ⬇️
cpp_python 37.72% <7.24%> (-0.54%) ⬇️
petab 38.59% <27.82%> (-0.28%) ⬇️
petab_sciml 14.15% <85.21%> (?)
python 69.37% <56.23%> (-0.28%) ⬇️
sbmlsuite-jax 33.01% <14.78%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_export.py 96.89% <100.00%> (+<0.01%) ⬆️
python/sdist/amici/jax/__init__.py 100.00% <ø> (ø)
python/sdist/amici/jax/jaxcodeprinter.py 90.32% <100.00%> (+1.43%) ⬆️
python/sdist/amici/jax/model.py 86.85% <100.00%> (+0.30%) ⬆️
python/sdist/amici/jax/ode_export.py 88.33% <100.00%> (+1.06%) ⬆️
python/sdist/amici/petab/parameter_mapping.py 85.37% <100.00%> (+0.64%) ⬆️
python/sdist/amici/petab/petab_import.py 100.00% <100.00%> (ø)
python/sdist/amici/petab/sbml_import.py 74.60% <ø> (ø)
python/sdist/amici/petab/util.py 86.66% <ø> (ø)
python/sdist/amici/sbml_import.py 93.95% <100.00%> (+0.01%) ⬆️
... and 3 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FFroehlich
Copy link
Member Author

SciML tests pass locally with SBML validation disabled, tests failing due to PEtab-dev/petab_sciml_testsuite#14

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Please run pre-commit run --all-files before merging.

FFroehlich and others added 18 commits October 31, 2025 10:03
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@FFroehlich FFroehlich added this pull request to the merge queue Nov 1, 2025
Merged via the queue into main with commit 4360d5e Nov 1, 2025
30 of 31 checks passed
@FFroehlich FFroehlich deleted the jax_sciml branch November 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants