Skip to content

Event-handling during pre-equilibration ASA / ASA#2889

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:preeq_events_asa_asa
Jul 23, 2025
Merged

Event-handling during pre-equilibration ASA / ASA#2889
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:preeq_events_asa_asa

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 7, 2025

Handle events during pre-equilibration when sensitivities for both pre-equilibration and main simulation are computed via adjoint sensitivity analysis.

If there were any discontinuities encountered during forward simulation, perform regular backward simulation with event-handling instead of using the steady-state shortcuts.

Related to #2775.

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.99%. Comparing base (e366c5b) to head (351b5b1).
⚠️ Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
src/backwardproblem.cpp 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
- Coverage   79.58%   78.99%   -0.59%     
==========================================
  Files         362      362              
  Lines       23103    23128      +25     
  Branches     1587     1587              
==========================================
- Hits        18386    18270     -116     
- Misses       4706     4847     +141     
  Partials       11       11              
Flag Coverage Δ
cpp 74.92% <97.56%> (-0.02%) ⬇️
cpp_python 33.16% <19.51%> (-0.02%) ⬇️
petab 38.84% <12.19%> (-0.06%) ⬇️
python 73.77% <90.24%> (-0.02%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/backwardproblem.h 95.45% <100.00%> (+0.71%) ⬆️
include/amici/forwardproblem.h 97.39% <100.00%> (+0.04%) ⬆️
include/amici/rdata.h 100.00% <ø> (ø)
src/forwardproblem.cpp 90.35% <100.00%> (+0.04%) ⬆️
src/rdata.cpp 93.05% <100.00%> (+0.03%) ⬆️
src/backwardproblem.cpp 90.31% <94.73%> (-0.68%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the preeq_events_asa_asa branch 3 times, most recently from 6cfd7b1 to 39699a5 Compare July 10, 2025 12:21
@dweindl dweindl force-pushed the preeq_events_asa_asa branch 2 times, most recently from 8afc978 to 41e0c29 Compare July 17, 2025 10:46
@dweindl dweindl marked this pull request as ready for review July 17, 2025 10:50
@dweindl dweindl requested a review from a team as a code owner July 17, 2025 10:50
Handle events during pre-equilibration when sensitivities for both pre-equilibration and main simulation are computed via adjoint sensitivity analysis.
@dweindl dweindl force-pushed the preeq_events_asa_asa branch from 41e0c29 to 351b5b1 Compare July 22, 2025 11:17
@dweindl dweindl merged commit ddf9b72 into AMICI-dev:main Jul 23, 2025
18 of 19 checks passed
@dweindl dweindl deleted the preeq_events_asa_asa branch July 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants