Event-handling during pre-equilibration ASA / ASA#2889
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 23, 2025
Merged
Event-handling during pre-equilibration ASA / ASA#2889dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
10 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 79.58% 78.99% -0.59%
==========================================
Files 362 362
Lines 23103 23128 +25
Branches 1587 1587
==========================================
- Hits 18386 18270 -116
- Misses 4706 4847 +141
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6cfd7b1 to
39699a5
Compare
8afc978 to
41e0c29
Compare
Handle events during pre-equilibration when sensitivities for both pre-equilibration and main simulation are computed via adjoint sensitivity analysis.
41e0c29 to
351b5b1
Compare
FFroehlich
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle events during pre-equilibration when sensitivities for both pre-equilibration and main simulation are computed via adjoint sensitivity analysis.
If there were any discontinuities encountered during forward simulation, perform regular backward simulation with event-handling instead of using the steady-state shortcuts.
Related to #2775.