Make DEModel._sparsesyms symbols sympy.Symbols#2894
Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom Jul 22, 2025
Merged
Conversation
963a0cc to
94723c9
Compare
DEModel._sparsesyms
c62cbe6 to
c1a2693
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 79.55% 78.98% -0.57%
==========================================
Files 362 362
Lines 23106 23104 -2
Branches 1587 1587
==========================================
- Hits 18381 18248 -133
- Misses 4714 4845 +131
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DEModel._sparsesymsDEModel._sparsesyms symbols sympy.Symbols
Previously, sparse matrix symbols in `DEModel._sparsesyms` were strings, as opposed to other model "syms" which were `sympy.Symbol`. Make that consistent. Fixes AMICI-dev#1061.
FFroehlich
reviewed
Jul 22, 2025
FFroehlich
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, sparse matrix symbols in
DEModel._sparsesymswere strings, as opposed to other model "syms" which weresympy.Symbol. Make that consistent.Fixes #1061.