Fix EventHandlingSimulator::get_simulation_state#2901
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 16, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 80.31% 79.72% -0.59%
==========================================
Files 330 330
Lines 22641 22634 -7
Branches 1532 1530 -2
==========================================
- Hits 18184 18046 -138
- Misses 4447 4578 +131
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Previously, `get_simulation_state` not only created a `SimulationState` but also updated the current workspace. This is unexpected and causes problems when handling nested events when the workspace is updated but the solver was not reinitialized yet (kind of reverting the primary event assignment). Thus, decouple snapshotting of the current state from pulling Solver state.
69efb9a to
e485009
Compare
FFroehlich
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
get_simulation_statenot only created aSimulationStatebut also updated the current workspace. This is unexpected and causes problems when handling nested events when the workspace is updated but the solver was not reinitialized yet (kind of reverting the primary event assignment). Thus, decouple snapshotting of the current state from pulling Solver state.