Skip to content

Fix sensitivities w.r.t. unused log-scaled NaN parameters#2903

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_nan_sens
Jul 16, 2025
Merged

Fix sensitivities w.r.t. unused log-scaled NaN parameters#2903
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_nan_sens

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 16, 2025

When applying the chain rule factor, avoid NaN-propagation in case of zero-multiplications.

(Will allow enabling the ExampleJakstatAdjoint.SensitivityAdjointUnusedNanOutputs test (#686) after #2898.)

When applying the chain rule factor, avoid NaN-propagation in case of zero-multiplications.

(Will allow enabling the `ExampleJakstatAdjoint.SensitivityAdjointUnusedNanOutputs` test (AMICI-dev#686) after AMICI-dev#2898.)
@dweindl dweindl self-assigned this Jul 16, 2025
@dweindl dweindl marked this pull request as ready for review July 16, 2025 20:37
@dweindl dweindl requested a review from a team as a code owner July 16, 2025 20:37
@dweindl dweindl enabled auto-merge July 16, 2025 20:37
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.66%. Comparing base (f83f92d) to head (02851bc).
⚠️ Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
src/rdata.cpp 70.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
- Coverage   80.28%   79.66%   -0.62%     
==========================================
  Files         330      330              
  Lines       22660    22669       +9     
  Branches     1531     1538       +7     
==========================================
- Hits        18192    18059     -133     
- Misses       4458     4600     +142     
  Partials       10       10              
Flag Coverage Δ
cpp 75.44% <70.00%> (-0.04%) ⬇️
cpp_python 33.73% <33.33%> (+<0.01%) ⬆️
petab 39.13% <23.33%> (-0.02%) ⬇️
python 74.40% <60.00%> (-0.05%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/rdata.cpp 93.03% <70.00%> (-0.36%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Jul 16, 2025
Merged via the queue into AMICI-dev:main with commit 5e36d60 Jul 16, 2025
21 of 24 checks passed
@dweindl dweindl deleted the fix_nan_sens branch July 17, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants