Skip to content

Cleanup#2907

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:cleanup
Jul 22, 2025
Merged

Cleanup#2907
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:cleanup

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 17, 2025

Fix const, fix mismatching parameter names in declaration/definition, ...

@dweindl dweindl self-assigned this Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (34043c6) to head (473da67).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
swig/stdvec2numpy.h 0.00% 8 Missing ⚠️
src/solver_idas.cpp 12.50% 7 Missing ⚠️
src/edata.cpp 92.30% 2 Missing ⚠️
src/exception.cpp 66.66% 1 Missing ⚠️
src/misc.cpp 75.00% 1 Missing ⚠️
src/model_dae.cpp 85.71% 1 Missing ⚠️
src/sundials_linsol_wrapper.cpp 0.00% 1 Missing ⚠️
src/vector.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   79.55%   78.97%   -0.58%     
==========================================
  Files         362      362              
  Lines       23106    23105       -1     
  Branches     1587     1587              
==========================================
- Hits        18381    18247     -134     
- Misses       4714     4847     +133     
  Partials       11       11              
Flag Coverage Δ
cpp 74.89% <81.81%> (-0.01%) ⬇️
cpp_python 33.19% <40.49%> (+<0.01%) ⬆️
petab 38.90% <25.42%> (+<0.01%) ⬆️
python 73.75% <74.38%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/event.h 94.73% <100.00%> (ø)
include/amici/model_dae.h 75.00% <ø> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
include/amici/solver.h 94.11% <ø> (ø)
include/amici/vector.h 85.29% <100.00%> (ø)
src/backwardproblem.cpp 90.98% <100.00%> (ø)
src/cblas.cpp 100.00% <ø> (ø)
src/hdf5.cpp 86.26% <100.00%> (ø)
src/model_ode.cpp 70.81% <100.00%> (ø)
src/newton_solver.cpp 79.31% <ø> (ø)
... and 12 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review July 17, 2025 12:57
@dweindl dweindl requested a review from a team as a code owner July 17, 2025 12:57
@dweindl dweindl enabled auto-merge July 17, 2025 12:57
Fix const, fix mismatching parameter names in declaration/definition, ...
@dweindl dweindl added this pull request to the merge queue Jul 22, 2025
Merged via the queue into AMICI-dev:main with commit a43a7bf Jul 22, 2025
18 of 19 checks passed
@dweindl dweindl deleted the cleanup branch July 22, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants