Skip to content

code-gen: Prettier min/max#2909

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:pretty_minmax
Jul 18, 2025
Merged

code-gen: Prettier min/max#2909
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:pretty_minmax

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 17, 2025

Print n-ary min/max instead of nested min/max for n>2. More readable.

Print n-ary min/max instead of nested min/max for n>2.
More readable.
@dweindl dweindl requested a review from a team as a code owner July 17, 2025 20:15
@dweindl dweindl enabled auto-merge July 17, 2025 20:15
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.06%. Comparing base (167864b) to head (95b7efc).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/cxxcodeprinter.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2909      +/-   ##
==========================================
- Coverage   79.62%   79.06%   -0.56%     
==========================================
  Files         358      358              
  Lines       23033    23035       +2     
  Branches     1581     1581              
==========================================
- Hits        18339    18212     -127     
- Misses       4683     4812     +129     
  Partials       11       11              
Flag Coverage Δ
cpp 74.98% <80.00%> (+0.01%) ⬆️
cpp_python 33.17% <0.00%> (-0.01%) ⬇️
petab 38.98% <0.00%> (-0.01%) ⬇️
python 73.85% <80.00%> (+0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/cxxcodeprinter.py 95.57% <80.00%> (+0.07%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Jul 17, 2025
@dweindl dweindl added this pull request to the merge queue Jul 18, 2025
Merged via the queue into AMICI-dev:main with commit d4410f3 Jul 18, 2025
18 of 19 checks passed
@dweindl dweindl deleted the pretty_minmax branch July 18, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants