Fix Event.get_trigger_times for periodic functions#2915
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 20, 2025
Merged
Fix Event.get_trigger_times for periodic functions#2915dweindl merged 1 commit intoAMICI-dev:mainfrom
Event.get_trigger_times for periodic functions#2915dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
The previous implementation would maximally handle the first two roots of `sin(t)` correctly.
dweindl
force-pushed
the
fix_periodic_triggers
branch
from
f44a9a0 to
cc2000c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
- Coverage 79.63% 79.07% -0.57%
==========================================
Files 358 358
Lines 23037 23044 +7
Branches 1581 1581
==========================================
- Hits 18346 18222 -124
- Misses 4680 4811 +131
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Jul 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would maximally handle the first two roots of
sin(t)correctly.