No event trigger reinitialization after pre-equilibration and pre-simulation#2921
No event trigger reinitialization after pre-equilibration and pre-simulation#2921dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
- Coverage 79.58% 78.99% -0.59%
==========================================
Files 362 362
Lines 23128 23142 +14
Branches 1587 1590 +3
==========================================
- Hits 18406 18282 -124
- Misses 4711 4849 +138
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
preserve_heaviside
branch
from
c83019c to
cab7c63
Compare
dweindl
force-pushed
the
preserve_heaviside
branch
from
cab7c63 to
0a75a44
Compare
FFroehlich
left a comment
FFroehlich
left a comment
There was a problem hiding this comment.
What happens with events that would be triggered by resetting t_f to t_0?
| # E1 & E2 will both trigger during pre-equilibration and main | ||
| # simulation (Heaviside is reset after pre-equilibration) | ||
| # E1 & E2 will only trigger during pre-equilibration | ||
| # (Heaviside is not reset after pre-equilibration) |
There was a problem hiding this comment.
where is the Heaviside function here? I do think we should reset Heaviside functions, i.e. not reapply trigger initialisation but do reinitialise trigger function states.
There was a problem hiding this comment.
Ah, yeah, no Heaviside function there. I meant h.
I don't think I understand your suggestion. You suggest replacing reinitializing h by what?
There was a problem hiding this comment.
I think it would be good to test that we are properly reinitialising Heaviside variables, if we aren't already doing so.
There was a problem hiding this comment.
I think that is covered in the tests here.
I am not sure I understand which situation you mean. Wouldn't that be kind of what is tested with |
dweindl
force-pushed
the
preserve_heaviside
branch
from
0a75a44 to
8af3236
Compare
…ulation Meanwhile, events are handled during pre-equilibration and pre-simulation. So far, SBML's `event.trigger.initialValue` was applied at the beginning of each period. However, this should only be applied at the beginning of the very first simulation period. This is fixed and tested here. Closes AMICI-dev#2918.
dweindl
force-pushed
the
preserve_heaviside
branch
from
8af3236 to
de72ad9
Compare
2 participants
Meanwhile, events are handled during pre-equilibration and pre-simulation. So far, SBML's
event.trigger.initialValuewas applied at the beginning of each period. However, this should only be applied at the beginning of the very first simulation period. This is fixed and tested here.Closes #2918.