Fix pre-equilibration error with generate_sensitivity_code=False#2924
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 25, 2025
Merged
Fix pre-equilibration error with generate_sensitivity_code=False#2924dweindl merged 1 commit intoAMICI-dev:mainfrom
generate_sensitivity_code=False#2924dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Only call `Model::initializeStateSensitivities` if we are computing sensitivities. Fixes a recently introduced bug that results in a simulation error when running pre-equilibration with models that were imported with `generate_sensitivity_code=False`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
- Coverage 79.58% 78.99% -0.59%
==========================================
Files 362 362
Lines 23128 23130 +2
Branches 1587 1588 +1
==========================================
- Hits 18406 18272 -134
- Misses 4711 4847 +136
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only call
Model::initializeStateSensitivitiesif we are computing sensitivities. Fixes a recently introduced bug that results in a simulation error when running pre-equilibration with models that were imported withgenerate_sensitivity_code=False.