Skip to content

Handle events during backward simulation of post-equilibration#2925

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:posteq_events_asa
Jul 28, 2025
Merged

Handle events during backward simulation of post-equilibration#2925
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:posteq_events_asa

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 25, 2025

Event handling during forward simulation for post-equilibration was implemented in #2920. Event handling during backward simulation for post-equilibration was missing and is implemented here.

Closes #2775.

Event handling during forward simulation for post-equilibration was implemented in AMICI-dev#2920.
Event handling during backward simulation for post-equilibration was missing and is implemented here.

Closes AMICI-dev#2775.
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.01%. Comparing base (e430afc) to head (14e0abf).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/backwardproblem.cpp 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
- Coverage   79.57%   79.01%   -0.57%     
==========================================
  Files         362      362              
  Lines       23142    23153      +11     
  Branches     1590     1590              
==========================================
- Hits        18416    18294     -122     
- Misses       4715     4848     +133     
  Partials       11       11              
Flag Coverage Δ
cpp 74.94% <95.00%> (+<0.01%) ⬆️
cpp_python 33.12% <0.00%> (-0.06%) ⬇️
petab 38.79% <0.00%> (-0.03%) ⬇️
python 73.79% <90.00%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/backwardproblem.cpp 90.33% <95.00%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Jul 25, 2025
@dweindl dweindl marked this pull request as ready for review July 25, 2025 21:20
@dweindl dweindl requested a review from a team as a code owner July 25, 2025 21:20
@dweindl dweindl merged commit 24a6cf4 into AMICI-dev:main Jul 28, 2025
18 of 19 checks passed
@dweindl dweindl deleted the posteq_events_asa branch July 28, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event-handling during preequilibration, presimulation and post-equilibration

2 participants