Skip to content

Fix handling of initial assignments containing splines#2943

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:x0_spl
Aug 29, 2025
Merged

Fix handling of initial assignments containing splines#2943
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:x0_spl

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Aug 28, 2025

Currently, x0 must not depend on splines. Therefore, substitute the spline symbol by its piecewise expression when compiling x0 expressions.

Reported by @m-philipps.

Currently, `x0` must not depend on splines. Therefore, substitute the spline symbol by it piecewise expression when compiling x0 expressions.

Reported by @m-philipps.
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.01%. Comparing base (17dbad1) to head (5f8824f).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
- Coverage   79.59%   79.01%   -0.59%     
==========================================
  Files         362      362              
  Lines       23175    23180       +5     
  Branches     1588     1588              
==========================================
- Hits        18446    18315     -131     
- Misses       4717     4853     +136     
  Partials       12       12              
Flag Coverage Δ
cpp 75.73% <100.00%> (+0.77%) ⬆️
cpp_python 33.15% <20.00%> (-0.01%) ⬇️
petab 38.80% <20.00%> (-0.01%) ⬇️
python 73.80% <100.00%> (-0.02%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 80.26% <100.00%> (-11.87%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-philipps
Copy link

Thanks a lot!

@dweindl dweindl marked this pull request as ready for review August 28, 2025 12:13
@dweindl dweindl requested a review from a team as a code owner August 28, 2025 12:13
@dweindl dweindl enabled auto-merge August 28, 2025 12:14
@dweindl dweindl self-assigned this Aug 28, 2025
@dweindl dweindl added this pull request to the merge queue Aug 29, 2025
Merged via the queue into AMICI-dev:main with commit a640291 Aug 29, 2025
24 of 25 checks passed
@dweindl dweindl deleted the x0_spl branch August 30, 2025 08:53
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 2, 2025
Currently, `x0` must not depend on splines. Therefore, substitute the spline symbol by it piecewise expression when compiling x0 expressions.

Reported by @m-philipps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants