Fix CMAKE_PARENT_LIST_FILE issues#2949
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Sep 19, 2025
Merged
Conversation
dweindl
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
- Coverage 79.41% 79.40% -0.01%
==========================================
Files 362 362
Lines 23183 23183
Branches 1588 1588
==========================================
- Hits 18410 18409 -1
- Misses 4761 4762 +1
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
`CMAKE_PARENT_LIST_FILE` produces inconsistent paths in different cmake versions. Unclear. Don't use it. Fixes ``` CMake Error at cmake/version.cmake:16 (file): file STRINGS file "/home/runner/work/AMICI/version.txt" cannot be read. ```
dweindl
force-pushed
the
fix_cmake_410
branch
from
ccf31d9 to
1f76abe
Compare
FFroehlich
approved these changes
Sep 19, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 2, 2025
`CMAKE_PARENT_LIST_FILE` produces inconsistent paths in different cmake versions. Unclear. Don't use it. Fixes ``` CMake Error at cmake/version.cmake:16 (file): file STRINGS file "/home/runner/work/AMICI/version.txt" cannot be read. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_PARENT_LIST_FILEproduces inconsistent paths in different cmake versions. Unclear. Don't use it.Fixes
(https://github.com/AMICI-dev/AMICI/actions/runs/17787055064/job/50556532173)