ReturnDataView.{preeq,posteq}_status to list[SteadyStateStatus]; squeeze numsteps#2954
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Oct 3, 2025
Merged
ReturnDataView.{preeq,posteq}_status to list[SteadyStateStatus]; squeeze numsteps#2954dweindl merged 1 commit intoAMICI-dev:mainfrom
ReturnDataView.{preeq,posteq}_status to list[SteadyStateStatus]; squeeze numsteps#2954dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2954 +/- ##
==========================================
- Coverage 76.60% 75.98% -0.62%
==========================================
Files 307 307
Lines 20134 20136 +2
Branches 1553 1554 +1
==========================================
- Hits 15423 15300 -123
- Misses 4698 4823 +125
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…squeeze numsteps * `ReturnDataView.posteq_numsteps` and `ReturnDataView.posteq_numsteps` now return a one-dimensional array of shape `(num_timepoints,)` instead of a two-dimensional array of shape `(1, num_timepoints)`. * `ReturnDataView.posteq_status` and `ReturnDataView.preeq_status` now return `list[SteadyStateStatus]` instead of an `ndarray[int]` of shape `(1, 3)`. Closes AMICI-dev#1944.
FFroehlich
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
ReturnDataView.posteq_numstepsandReturnDataView.posteq_numstepsnow return a one-dimensional array of shape(num_timepoints,)instead of a two-dimensional array of shape(1, num_timepoints).ReturnDataView.posteq_statusandReturnDataView.preeq_statusnow returnlist[SteadyStateStatus]instead of anndarray[int]of shape(1, 3). Closes ReturnDataView.{preeq,posteq}_status should be 1D-arrays #1944.