Skip to content

Clean up symbolic_functions.{cpp,h}#2956

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:cleanup_symfun
Oct 3, 2025
Merged

Clean up symbolic_functions.{cpp,h}#2956
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:cleanup_symfun

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 2, 2025

Remove MATLAB leftovers. Clean up.

Related to #2727.

@dweindl dweindl mentioned this pull request Oct 2, 2025
15 tasks
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.45%. Comparing base (570c71d) to head (4f56ebe).
⚠️ Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
src/solver.cpp 87.50% 2 Missing ⚠️
src/symbolic_functions.cpp 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2956      +/-   ##
==========================================
- Coverage   77.12%   76.45%   -0.68%     
==========================================
  Files         307      307              
  Lines       19947    19925      -22     
  Branches     1508     1502       -6     
==========================================
- Hits        15385    15234     -151     
- Misses       4549     4678     +129     
  Partials       13       13              
Flag Coverage Δ
cpp 72.61% <85.18%> (-0.01%) ⬇️
cpp_python 38.22% <55.55%> (+0.05%) ⬆️
petab 39.44% <29.16%> (+0.05%) ⬆️
python 70.36% <66.66%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/edata.h 100.00% <ø> (ø)
src/edata.cpp 88.75% <100.00%> (ø)
src/rdata.cpp 82.57% <100.00%> (ø)
src/solver.cpp 80.87% <87.50%> (ø)
src/symbolic_functions.cpp 91.30% <33.33%> (-2.03%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 3, 2025 06:57
@dweindl dweindl requested a review from a team as a code owner October 3, 2025 06:57
@dweindl dweindl self-assigned this Oct 3, 2025
Remove MATLAB leftovers. Clean up.

Related to AMICI-dev#2727.
@dweindl dweindl enabled auto-merge October 3, 2025 07:52
@dweindl dweindl added this pull request to the merge queue Oct 3, 2025
Merged via the queue into AMICI-dev:main with commit dbf0ac2 Oct 3, 2025
17 of 18 checks passed
@dweindl dweindl deleted the cleanup_symfun branch October 3, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants